Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

milestoning improvements #3297

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

YannanGao-gs
Copy link
Contributor

@YannanGao-gs YannanGao-gs commented Jun 27, 2024

Summary

milestoning improvements

  • Support reset query content also will reset milestoning config.
  • StartDate and EndDate parameters should be undeletable if used in query.
  • Hide avaialble parameter and constant lists when choosing allVersions

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner June 27, 2024 20:18
Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: e2c1e65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@finos/legend-query-builder Patch
@finos/legend-application-query Patch
@finos/legend-application-studio Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 54.66667% with 34 lines in your changes missing coverage. Please review.

Project coverage is 47.86%. Comparing base (b897478) to head (e2c1e65).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3297      +/-   ##
==========================================
+ Coverage   47.77%   47.86%   +0.09%     
==========================================
  Files        2019     2019              
  Lines      343352   343383      +31     
  Branches    15133    14783     -350     
==========================================
+ Hits       164029   164371     +342     
- Misses     178447   178619     +172     
+ Partials      876      393     -483     
Files Coverage Δ
packages/legend-query-builder/src/index.ts 0.00% <0.00%> (ø)
...gend-query-builder/src/stores/QueryBuilderState.ts 73.05% <0.00%> (-0.09%) ⬇️
...stores/milestoning/QueryBuilderMilestoningState.ts 75.52% <83.33%> (+0.12%) ⬆️
...c/components/Core_LegendQueryApplicationPlugin.tsx 50.13% <8.33%> (-0.63%) ⬇️
...etch-structure/QueryBuilderResultModifierPanel.tsx 86.49% <61.22%> (+0.08%) ⬆️

... and 336 files with indirect coverage changes

@MauricioUyaguari MauricioUyaguari merged commit db471ef into finos:master Jun 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants