Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension support for external language Morphir #640

Merged
merged 45 commits into from
Nov 29, 2021

Conversation

CptTeddy
Copy link

@CptTeddy CptTeddy commented Nov 2, 2021

Summary

This PR aims at providing Morphir IR generation capability to Studio among its supported file generation flows, via adding an extension to Legend Studio.

  • File generation dropdown should include Morphir as an additional type for Functions.
  • Users should be able to view Json style Morphir IR with valid source information in the file generation content viewer.
  • Two buttons should be present on top of the file generation viewer, which redirect to Morphir visualizer and Bosque feedback viewer, respectively, powered by Linter, with configurable urls.
  • Refactor GraphGenerationState's enabled file generation types for object types to extension.
  • Refactor roundtrip to grammar and back to PureModelContextData to use PureModelContextText.

How did you test this change?

pr-recording-two.mov

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2021

🦋 Changeset detected

Latest commit: 4f77f85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@finos/legend-art Minor
@finos/legend-extension-external-language-morphir Patch
@finos/legend-graph Patch
@finos/legend-studio Minor
@finos/legend-studio-app Minor
@finos/legend-application Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-serializer Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-manual-tests Patch
@finos/legend-query-app Minor
@finos/legend-query Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-taxonomy-app Minor
@finos/legend-taxonomy Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-studio-deployment Minor
@finos/legend-graph-extension-collection Patch
@finos/legend-query-deployment Minor
@finos/legend-taxonomy-deployment Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CptTeddy CptTeddy marked this pull request as draft November 2, 2021 13:45
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #640 (4f77f85) into master (0bd8361) will decrease coverage by 0.05%.
The diff coverage is 16.09%.

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
- Coverage   43.36%   43.30%   -0.06%     
==========================================
  Files         914      915       +1     
  Lines       40666    40773     +107     
  Branches     9336     9355      +19     
==========================================
+ Hits        17633    17657      +24     
- Misses      22964    23048      +84     
+ Partials       69       68       -1     
Impacted Files Coverage Δ
...h/src/models/protocols/pure/v1/engine/V1_Engine.ts 5.23% <0.00%> (-0.10%) ⬇️
...ure/v1/engine/generation/V1_FileGenerationInput.ts 20.00% <ø> (ø)
packages/legend-studio-app/src/index.tsx 0.00% <ø> (ø)
...element-generation-editor/FileGenerationEditor.tsx 11.32% <0.00%> (-0.20%) ⬇️
...ir/src/components/ELMorphir_LegendStudioPlugin.tsx 5.17% <5.17%> (ø)
...ation/pureProtocol/V1_PureProtocolSerialization.ts 60.41% <36.36%> (-7.16%) ⬇️
...io/src/stores/editor-state/GraphGenerationState.ts 25.94% <77.77%> (-0.03%) ⬇️
...c/stores/editor-state/FileGenerationViewerState.ts 8.00% <0.00%> (-1.10%) ⬇️
...rc/stores/sidebar-state/WorkspaceWorkflowsState.ts 15.18% <0.00%> (-0.20%) ⬇️
... and 17 more

@akphi akphi added this to the 2.0.0 milestone Nov 3, 2021
@CptTeddy CptTeddy changed the title Add Morphir as generation type. Add Legend Studio Extension for External Language Morphir. Nov 3, 2021
@CptTeddy CptTeddy marked this pull request as ready for review November 24, 2021 22:47
.changeset/cuddly-sloths-laugh.md Outdated Show resolved Hide resolved
.changeset/four-pots-beam.md Show resolved Hide resolved
.changeset/nine-shrimps-sin.md Outdated Show resolved Hide resolved
.changeset/nine-shrimps-sin.md Outdated Show resolved Hide resolved
packages/legend-studio-app/src/index.tsx Outdated Show resolved Hide resolved
@akphi
Copy link
Contributor

akphi commented Nov 28, 2021

@CptTeddy just a small comment. I think next time, for things that you agreed with and fixed, you can mark the conversation as Resolved. You should only leave the thread that you need clarification/discussion open so it would save me or other reviewers some time as we don't have to go back up and close them. Thanks!!

@akphi akphi merged commit b5ce0f9 into finos:master Nov 29, 2021
@github-actions github-actions bot mentioned this pull request Nov 29, 2021
@akphi akphi mentioned this pull request Nov 29, 2021
5 tasks
akphi added a commit to akphi/legend-studio that referenced this pull request Nov 30, 2021
@akphi akphi modified the milestone: 2.0.0 Dec 1, 2021
akphi added a commit to akphi/legend-studio that referenced this pull request Dec 2, 2021
akphi added a commit that referenced this pull request Dec 3, 2021
* add tagging mechanism for query

* bump dependencies

* improve webpack development build performance

* cleanup file generation logic post #640

* taxonomy: properly expand tree when node is opened from search

* fix search query endpoint

* show warning when detecting duplicated projection column

* refactor LegendApplication plugin manager

* create event notifier mechanism

* legend query: fix a bug with creating new query from an existing query

* minor fixes post #679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants