Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mao's scanning actions from FINOS security scanning #382

Merged
merged 24 commits into from
Apr 25, 2023

Conversation

robmoffat
Copy link
Member

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@TheJuanAndOnly99
Copy link
Member

/easycla

1 similar comment
@jarias-lfx
Copy link

/easycla

@robmoffat
Copy link
Member Author

@maoo @vaibhav-db

this basically works now, except that there is a new critical CVE for Spring Boot and so our white source / Dependency Checks are failing.

Once a new version gets published we can release. Please review + approve.

@maoo
Copy link
Member

maoo commented Apr 20, 2023

@robmoffat - apparently spring-web-5.3.26.jar is affected by CVE-2016-1000027 , which states:

Pivotal Spring Framework through 5.3.16 suffers from a potential remote code execution (RCE) issue if used for Java deserialization of untrusted data. Depending on how the library is implemented within a product, this issue may or not occur, and authentication may be required. NOTE: the vendor's position is that untrusted data is not an intended use case. The product's behavior will not be changed because some users rely on deserialization of trusted data.

If you don't use spring-web for deserialization of untrusted data (that is, data that is manually entered), I'd suggest to add this to allow-list.xml with a note that explains why the CVE can be safely ignored; see https://nvd.nist.gov/vuln/detail/cve-2016-1000027

@robmoffat
Copy link
Member Author

@vaibhav-db let's review. Also took out white source for future PRs

@pankajpkhandelwal-db pankajpkhandelwal-db self-assigned this Apr 25, 2023
@pankajpkhandelwal-db pankajpkhandelwal-db removed their assignment Apr 25, 2023
@pankajpkhandelwal-db pankajpkhandelwal-db merged commit 5911655 into spring-bot-master Apr 25, 2023
9 of 10 checks passed
@pankajpkhandelwal-db pankajpkhandelwal-db deleted the scanning-github-actions branch April 25, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants