MS Teams Upload attachment feature #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing bot team framework Merge in SYMPHONYP/symphony-java-toolkit from feature/SYMPHONYP-1106-download-feature-in-spring-bot-team-framework to spring-bot-master-db * commit '15451c97348710774d7276e65acacbba9271d0f1': SYMPHONYP-1106 upload attachment feature in famework Fix for finos#342 update pom Update CHANGES.md Update CHANGES.md
robmoffat
requested changes
Apr 29, 2024
| import org.finos.springbot.workflow.java.mapping.ChatHandlerExecutor; | ||
|
|
||
| /** | ||
| * Get chat button detail in controller |
There was a problem hiding this comment.
Can you describe what this is for?
There was a problem hiding this comment.
As we discussed last time, we need button information on controller method. For that we have added this class.
| import com.microsoft.bot.schema.teams.FileConsentCardResponse; | ||
| import com.microsoft.bot.schema.teams.FileInfoCard; | ||
|
|
||
| public class FileActivityHandler extends MessageActivityHandler { |
There was a problem hiding this comment.
Please check the code coverage as a result of adding this. I have a feeling there will need to be some unit tests added to make sure this works.
There was a problem hiding this comment.
Sure, I will check the code coverage and also add the unit testcases.
There was a problem hiding this comment.
committed testcases..
There was a problem hiding this comment.
Hi @robmoffat ,
Now code coverage is 72.53%
There was a problem hiding this comment.
Merge in SYMPHONYP/symphony-java-toolkit from feature/SYMPHONYP-1106-download-feature-in-spring-bot-team-framework to spring-bot-master-db * commit '9129c834f6119ed03b861233bb6c6dc1e1ff4b08': SYMPHONYP-1118 test case for File handler
…ing bot team framework Merge in SYMPHONYP/symphony-java-toolkit from feature/SYMPHONYP-1106-download-feature-in-spring-bot-team-framework to spring-bot-master-db * commit '4958a388f0b9aa305b75a40a0beddee0275de69c': SYMPHONYP-1118 test case for File handler SYMPHONYP-1118 test case for File handler SYMPHONYP-1118 test case for File handler
robmoffat
approved these changes
May 22, 2024
…ing bot team framework Merge in SYMPHONYP/symphony-java-toolkit from feature/SYMPHONYP-1106-download-feature-in-spring-bot-team-framework to spring-bot-master-db * commit '224316daf824e9ee8ffb34a1e7583a2e797605e4': Release note Release note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.