-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitoring api: Support query parameters #147
Merged
symphony-soufiane
merged 11 commits into
finos:master
from
symphony-soufiane:monitoring-api-query-params
Sep 26, 2022
Merged
Monitoring api: Support query parameters #147
symphony-soufiane
merged 11 commits into
finos:master
from
symphony-soufiane:monitoring-api-query-params
Sep 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion. Unit tests will be corrected/added in next commit
symphony-soufiane
changed the title
WIP: first take on query params handling
Monitoring api: Support query parameters
Sep 21, 2022
…endpoint. Fixed bug in list instance activities when the instance id is not related to the provided workflow Id
…fy if a provided instance belongs to the provided workflow. Changed query parameter filters, based on date, to ISO 8601 instead of a long timestamp. Fixed and added unit tests. More tests will be fixed and added in next commit
…pleted and failed ones depending on th endActivityId referenced in the historicProcessInstance, if it is an endEvent then the instance has succeeded, otherwise it is a failing one.
workflow-bot-app/src/main/java/com/symphony/bdk/workflow/api/v1/dto/StatusEnum.java
Show resolved
Hide resolved
...mphony/bdk/workflow/engine/camunda/monitoring/repository/ActivityCmdaApiQueryRepository.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/symphony/bdk/workflow/monitoring/repository/WorkflowInstQueryRepository.java
Show resolved
Hide resolved
...mphony/bdk/workflow/engine/camunda/monitoring/repository/ActivityCmdaApiQueryRepository.java
Outdated
Show resolved
Hide resolved
workflow-bot-app/src/main/java/com/symphony/bdk/workflow/security/AuthorizationAspect.java
Outdated
Show resolved
Hide resolved
workflow-bot-app/src/main/java/com/symphony/bdk/workflow/security/AuthorizationAspect.java
Outdated
Show resolved
Hide resolved
workflow-bot-app/src/main/java/com/symphony/bdk/workflow/security/AuthorizationAspect.java
Outdated
Show resolved
Hide resolved
...ow-bot-app/src/main/java/com/symphony/bdk/workflow/monitoring/service/MonitoringService.java
Show resolved
Hide resolved
yinan-symphony
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we added the support of query parameters to filter results.
More changes have been done in this PR: