Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve in-mem typeahead performance #1353

Open
junaidzm13 opened this issue May 21, 2024 · 0 comments
Open

Improve in-mem typeahead performance #1353

junaidzm13 opened this issue May 21, 2024 · 0 comments
Assignees

Comments

@junaidzm13
Copy link
Contributor

We're currently sorting all table rows only to get 10 distinct values in the end on every typeahead RPC call. Which turns out to be a bottleneck if we have a large table. Local tests have shown that it takes around 1 second for the method to return 10 distinct values for a table with 1 million rows.

It might be better if we can instead return the first 10 distinct values that match the given criteria / filters and not care about sorting (since we're returning only 10 values, sorted / unsorted wouldn't make much of a diff in terms of UX since the user doesn't have the scroll functionality anyways).

@junaidzm13 junaidzm13 changed the title Improve typeahead performance Improve in-mem typeahead performance May 21, 2024
@junaidzm13 junaidzm13 self-assigned this May 21, 2024
@junaidzm13 junaidzm13 moved this to 🏗 In progress in Vuu board May 21, 2024
@junaidzm13 junaidzm13 moved this from 🏗 In progress to 🔖 To be merged in Vuu board May 22, 2024
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue May 23, 2024
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue May 23, 2024
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue May 23, 2024
- the plan is to add a separate test suite for benchmark tests
  as they are usually more expensive to run.
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue May 23, 2024
…urned are unique. Adding test for when some of the values are null
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 23, 2024
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 23, 2024
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 23, 2024
- the plan is to add a separate test suite for benchmark tests
  as they are usually more expensive to run.
junaidzm13 pushed a commit to junaidzm13/vuu that referenced this issue May 23, 2024
…urned are unique. Adding test for when some of the values are null
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 23, 2024
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 23, 2024
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 23, 2024
- the plan is to add a separate test suite for benchmark tests
  as they are usually more expensive to run.
junaidzm13 pushed a commit to junaidzm13/vuu that referenced this issue May 23, 2024
…urned are unique. Adding test for when some of the values are null
heswell added a commit that referenced this issue May 23, 2024
…ormance

#1353 improve in-mem typeahead's performance
@junaidzm13 junaidzm13 moved this from 🔖 To be merged to 👀 To be tested in QA in Vuu board May 30, 2024
@naleeha naleeha moved this from 👀 To be tested in QA to ✅ Done in Vuu board Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant