1296 schema mapper type conversions #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
junaidzm13
force-pushed
the
1296-schema-mapper-type-conversions
branch
4 times, most recently
from
9ffc02a
to
8998b9c
Compare
… converters finos#1296 support for conversion from primitive to wrapper types for consistency finos#1296 add TypeConverterContainer and related tests Also some improvements and refactoring on previous changes finos#1296 improvements and refactoring on previous changes / TypeConverterContainer enhancements / TypeUtils introduced finos#1296 add 3 more default type converters + tests for DefaultTypeConverters
junaidzm13
force-pushed
the
1296-schema-mapper-type-conversions
branch
from
8998b9c
to
fa6a067
Compare
- this commit also adds more DefaultTypeConverters and some missing tests for DataType.parseToDataType.
- also removes `convertExternalValueToString` from `SchemaMapper` and moves it to Filtering use-case as it has nothing to do with schema mapping logic.
…ConverterContainer - this allows users to specify custom external-value -> sql-string converters.
- it is now just a utility to convert column value (String) from ANTLR to external value (original external date type) that will then be used with external data source for filtering. - In the process makes it responsible only for one thing i.e. parse column value (String) to external value's data type. Should not care about how we convert the resulting external value to a String understood by SQL. That logic's been moved back to IgniteSqlFilterClause. - also renames SqlStringConverterContainer to less verbose ToSqlStringContainer.
junaidzm13
force-pushed
the
1296-schema-mapper-type-conversions
branch
from
fa6a067
to
2e773e1
Compare
naleeha
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.