Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global store for common data #6999

Open
davidwatkins73 opened this issue Feb 22, 2024 · 3 comments
Open

Add global store for common data #6999

davidwatkins73 opened this issue Feb 22, 2024 · 3 comments
Labels
task Not directly feature related (i.e. dependency upgrade, docs, etc)
Milestone

Comments

@davidwatkins73
Copy link
Member

Description

A recent issue (#6997) has highlighted that the approach to passing common data between pages and component is not consistent. This issue should remedy this by creating a set of global stores that all pages/components can include.
Candidate stores would include:

  • primaryEntityReference (or parentEntityReference)
  • pageName
  • filters
  • user
  • permissions

Resourcing

We intend to contribute this feature

@davidwatkins73 davidwatkins73 added the task Not directly feature related (i.e. dependency upgrade, docs, etc) label Feb 22, 2024
@davidwatkins73 davidwatkins73 added this to the next : 1.59 milestone Feb 22, 2024
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Feb 23, 2024
- primary ref was not being updated correctly

Note: this is a bit of a hack. An issue to clean up this approach
has been raised (finos#6999)

#CTCTOWALTZ-3046
finos#6997
@davidwatkins73
Copy link
Member Author

We already have a page-navigation-store::pageInfo store which is populated by the angular router or can be written to if a page transition is required.

image

The isNotification attribute differentiates between the notifications and the pushes.

@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Feb 25, 2024

Would need to do this for all the view pages:

  • actor
  • app-group
  • app
  • assessment-definition
  • attestation-run
  • change-initiative-external-id
  • change-initiative
  • change-set
  • data-type
  • database
  • entity-relationship
  • entity-statistic
  • flow-classification-rule
  • flow-diagram
  • involvement-kind
  • legal-entity-relationship-kind
  • legal-entity-relationship
  • legal-entity
  • licence
  • logical-data-element
  • logical-flow
  • measurable-rating
  • measurable
  • overlay-diagram-instance
  • person-entity-statistic
  • person
  • physical-flow
  • physical-specification
  • process-diagram
  • report-grid
  • roadmap
  • scenario
  • server
  • software-package
  • static-panels
  • survey-instance-response
  • survey-run
  • survey-template
  • unit

These views I don't think would be required:

  • actor-list
  • actors
  • app-asset-code
  • attestation-instance-list-user
  • dynamic-sections
  • embed
  • entity-named-node-types
  • euda-list
  • hierarchies
  • involvement-kinds
  • home
  • legal-entity-relationship-kind-list
  • orphans
  • reassign-recipients
  • recalculate
  • related-measurable-item
  • relationship-kinds
  • survey-instance-list-user
  • tag-application
  • tag-physical-flow

@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Feb 26, 2024

This could be a large task.

We need to think about sections/components which can be used in different contexts on the same page (or at least differ from the parent page). This would require us to have an override mechanism, perhaps something like:

import {pageRef} from "../../../svelte-stores/globals";

export let parentEntityRef;  // passed in via param
let ref = coalseceWithStores(parentEntityRef, getContext("inheritedPageRef"), pageRef)

davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Not directly feature related (i.e. dependency upgrade, docs, etc)
Projects
None yet
Development

No branches or pull requests

1 participant