Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying I_8fs(holzapfelogden.py) to take isochoric argument #79

Merged
merged 7 commits into from
Sep 5, 2023
Merged

Modifying I_8fs(holzapfelogden.py) to take isochoric argument #79

merged 7 commits into from
Sep 5, 2023

Conversation

ramayzoraiz
Copy link
Contributor

Fixes #

Proposed Changes

-isochoric=self.isochoric as argument in holzapfelogden.py
-def I8(F, a0, b0, isochoric=False) modification in kinematics.py

Updating I_8fs so that it takes isochoric argument
Updating I_8 so that it accounts for isochoric argument
Copy link
Owner

@finsberg finsberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change this to and if-else statement, don't you agree?

src/pulse/kinematics.py Outdated Show resolved Hide resolved
src/pulse/kinematics.py Outdated Show resolved Hide resolved
src/pulse/kinematics.py Outdated Show resolved Hide resolved
src/pulse/kinematics.py Outdated Show resolved Hide resolved
@finsberg finsberg merged commit 17d4220 into finsberg:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants