Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct parameter in benchmark problems #98

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Use correct parameter in benchmark problems #98

merged 4 commits into from
Apr 3, 2024

Conversation

finsberg
Copy link
Owner

@finsberg finsberg commented Apr 1, 2024 •
edited
Loading

Fixes #97

Output from problem 2 is now

Get longitudinal position of endocardial apex: 26.5328 mm
Get longitudinal position of epicardial apex: 28.1790 mm

and problem 3 is

Get longitudinal position of endocardial apex: -11.9958 mm
Get longitudinal position of epicardial apex: -15.2232 mm

Main bug was

  1. Passed the wrong parameter (i.e CC instead of C) in the material model.
  2. Something wrong with the mesh or fibers stored in pulse.

We will now create the mesh automatically using cardiac-geometries

@finsberg finsberg merged commit 42f4b8d into main Apr 3, 2024
3 checks passed
@finsberg finsberg mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Benchmark Problems 2 & 3
1 participant
@finsberg