Add includeEncrypted parameter #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolasStelmakh
force-pushed
the
update/received-and-sent-fio-requests-getters
branch
from
a0e6949
to
2c0db2a
Compare
andreyvEze
reviewed
Jan 28, 2022
| @@ -36,7 +38,7 @@ export class ReceivedFioRequests extends Query<ReceivedFioRequestsResponse> { | |||
| value.content = content | |||
| requests.push(value) | |||
| } catch (e) { | |||
| // | |||
| if (this.includeEncrypted) { requests.push(value) } | |||
There was a problem hiding this comment.
ok, but { } is required in the tslint rules
andreyvEze
reviewed
Jan 28, 2022
src/FIOSDK.ts
Outdated
| @@ -601,7 +600,7 @@ export class FIOSDK { | |||
| [{ | |||
| chain_code: chainCode, | |||
| token_code: tokenCode, | |||
| public_address: publicAddress | |||
| public_address: publicAddress, | |||
There was a problem hiding this comment.
please remove all of the changes that not relate to the feature, and create separate PR for it
andreyvEze
reviewed
Jan 28, 2022
| @@ -36,7 +38,7 @@ export class SentFioRequests extends Query<SentFioRequestResponse> { | |||
| value.content = content | |||
| requests.push(value) | |||
| } catch (e) { | |||
| // | |||
| if (this.includeEncrypted) { requests.push(value) } | |||
NikolasStelmakh
force-pushed
the
update/received-and-sent-fio-requests-getters
branch
from
2c0db2a
to
2903928
Compare
andreyvEze
force-pushed
the
update/received-and-sent-fio-requests-getters
branch
from
2903928
to
3d999f1
Compare
andreyvEze
approved these changes
Feb 22, 2022
ericbutz
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.