Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature. DASH-628 Auth permission param in sign/push transaction #150

Merged
merged 4 commits into from
May 21, 2023
Merged

Feature. DASH-628 Auth permission param in sign/push transaction #150

merged 4 commits into from
May 21, 2023

Conversation

trukhilio
Copy link
Contributor

@trukhilio trukhilio commented May 12, 2023 •
edited
Loading

  • Use authPermission in sign/push transaction.
  • Receive params for pushTransaction in object instead of multiple arguments
  • Update documentation

@trukhilio trukhilio requested a review from edrotthoff May 12, 2023 08:19
@trukhilio trukhilio force-pushed the feature/DASH-628-support-custom-permission-in-sdk branch from 325bc15 to 6acaa20 Compare May 12, 2023 08:35
edrotthoff
edrotthoff reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@edrotthoff edrotthoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still reviewing this PR, can you add tests that are similar to fio.test register-renew-fio-domain.js...I think we should have tests in the SDK that use an auth other than active (or default)....thank you....more comments may come

@trukhilio trukhilio force-pushed the feature/DASH-628-support-custom-permission-in-sdk branch from 4d75588 to a2461f4 Compare May 17, 2023 17:44
edrotthoff
edrotthoff approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@edrotthoff edrotthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this branch has been reviewed and qa tested....and can be merged

@edrotthoff edrotthoff merged commit 6159adc into develop May 21, 2023
@trukhilio trukhilio deleted the feature/DASH-628-support-custom-permission-in-sdk branch May 22, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edrotthoff edrotthoff edrotthoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trukhilio @edrotthoff