Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sec-Websocket-origin no longer mandatory in protocol-upgrade headers. #174

Closed
wants to merge 2 commits into from
Closed

Conversation

smandy
Copy link

@smandy smandy commented Jan 9, 2016

I was just messing around with dart language. Dart:io doesn't send Sec-Websocket-Origin header so a dart websocket can't talk to cyclone websocket. I believe this header is no longer mandatory. I'm not sure if "UNKNOWN" is an appropriate value but this seems to fix dart<->cyclone interop.

@dpnova
Copy link
Collaborator

dpnova commented Jan 10, 2016

Thanks for this Andy.

I had a look at what tornado is doing here and it's slightly different: http://www.tornadoweb.org/en/stable/_modules/tornado/websocket.html

Could you try out a change like that and see if it satisfies Dart:io and your needs? I'd rather keep behaviour in line with tornado upstream if possible.

Thanks!

@smandy
Copy link
Author

smandy commented Jan 17, 2016

Hey sorry for late reply. I'll have a look. It looks like the cyclone and tornado websocket impls have diverged a bit so some interpretation is required :-) It looks like if origin is absent all that's required would be to ignore ( and maybe omit ORIGIN in the websocket upgrade response). I'll try that and see how it looks...

A.

@coveralls
Copy link

coveralls commented Jun 16, 2016

Coverage Status

Coverage remained the same at 75.093% when pulling 181f9e8 on smandy:master into f324205 on fiorix:master.

@fiorix
Copy link
Owner

fiorix commented Jul 13, 2019

Stuck for too long, lost track.

@fiorix fiorix closed this Jul 13, 2019
@smandy
Copy link
Author

smandy commented Jul 13, 2019

Yeah fair enough. I've pretty much stopped my soujourn with Dart so best to just kill these things off rather than let them linger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants