Switch to python3

[waghanza]

Hi,

This PR break python2 compatibility

Thanks for @ygl-rg for his work 🎉

Checklist :

• Test passes on python3 (at least 3.5 / 3.6 / 3.7)
• Documentation is updated (to warn about python3 support dropping)

@fiorix To keep this PR as minimalistic as I can, I think this is it (I'll add other feature later and / or maybe drop python3.5 support)

/cc @dpnova @posita

Regards,

[coveralls]

Coverage remained the same at ?% when pulling 533cd5c on waghanza:python3 into 9f75848 on fiorix:master.

[fiorix]

Woah, big PR :)

It actually looks alright. I'm surprised all tests pass, but wouldn't be surprised if it'd still break things silently given not everything is covered in these tests.

Have you looked at the travis output? It fails on python nightly - might be because of something else, but worth a glance.

[fiorix]

What do you think of 2 lasts ?

I don't even know what black is. For editor, I only use vim, so.. :)

[waghanza]

@fiorix black is a python formatter => https://black.readthedocs.io

behind the idea of using it is to clean / homogenize the code base

PS : it's the smallest I've found (used massively by mozilla)

[waghanza]

@fiorix the last is about keeping code base uniform along PR

[fiorix]

ah, black is like gofmt for go, cool; I'm ok with using it and avoiding people debating style / pepX :)

[fiorix]

I guess it doesn't have to be in the same PR. This one is long enough already.

[waghanza]

of course, I think about listing stuff in origin issue instead of here

[ygl-rg]

glad to see "all checks have passed"

[fiorix]

Hey could you please squash this in 1 commit before I merge it?

[waghanza]

Sure, I'll learn how to do it 😄 on monday

[waghanza]

I have squashed commits

[subyraman]

@fiorix do you have any thoughts about merging/releasing this? A number of us are excited for the possibility of this being Py3 compatible :)

[fiorix]

Hey all, this is fantastic work! Thank you so much.

[fiorix]

Made it release v1.3, and it should be pushed to pypi.