Non RPC function not able to be xml encoded properly

[adriantam]

After #75, the generated file contains request that cannot be properly XML encoded.

For example, see https://play.golang.org/p/1aVTcYXYb2j (which is derived from https://raw.githubusercontent.com/fiorix/wsdl2go/master/wsdlgo/testdata/data.golden) - the request cannot be XML encoded.

[kernle32dll]

That is strange. I did check that this did work while doing #75 . I will look into it.

[kernle32dll]

@adriantam Well, although your example was pointing at the wrong direction, as it points to a entirely different problem (trying to marshal a struct - which of course cannot work this way), I was able to find the problem.

Indeed, while doing #75 it seems I broke non-RPC - which is terribly bad. However, I have a fix ready, and will issue an PR. cc @fiorix

[fiorix]

Could you please add a test so this doesn't happen again in the future?

[kernle32dll]

@fiorix Yes and no. This is not as simple, as we require integrative full-stack / regression tests, which we don't have at the moment. Full-stack would mean generation of a wsdl file, and using said bindings with a locally setup mock server to verify correct / expected behavior. The problem is writing simple enough wsdl files, which can be used for such tests (they must be simple, so they can be properly mocked).

I will start working on my fork on such tests. But I don't suspect that they will be ready soon.

[fiorix]

This is cool, thanks. Take your time and have fun.