Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added version numbers to bower.json and package.json #915

Merged
merged 1 commit into from
Feb 22, 2017
Merged

Added version numbers to bower.json and package.json #915

merged 1 commit into from
Feb 22, 2017

Conversation

jwngr
Copy link

@jwngr jwngr commented Feb 22, 2017

Description

Catapult (the internal tool we use to release Firebase JavaScript libraries) now works without the 0.0.0 version placeholder in the bower.json and package.json files. So, we can finally add the actual version numbers back into these files.

Code sample

N/A

@jwngr jwngr requested a review from cbraynor February 22, 2017 18:03
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.716% when pulling 356640f on jw-add-version-numbers-to-json-files into e1dff6f on master.

cbraynor
cbraynor approved these changes Feb 22, 2017
View reviewed changes
Copy link

@cbraynor cbraynor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwngr jwngr assigned jwngr and unassigned cbraynor Feb 22, 2017
@jwngr jwngr merged commit 7e5a7e8 into master Feb 22, 2017
@jwngr jwngr deleted the jw-add-version-numbers-to-json-files branch February 22, 2017 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbraynor cbraynor cbraynor approved these changes

Assignees

@jwngr jwngr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwngr @coveralls @cbraynor