[firestore-translate-text] allow single language list #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ehesp
requested changes
Oct 16, 2019
| @@ -90,7 +90,7 @@ params: | |||
| For these codes, visit the [supported languages list](https://cloud.google.com/translate/docs/languages). | |||
| default: en,es,de,fr | |||
| example: en,es,de,fr | |||
| validationRegex: "^[a-zA-Z,-]+[a-zA-Z-]{2,}$" | |||
| validationRegex: "^[a-zA-Z,-]*[a-zA-Z-]{2,}$" | |||
There was a problem hiding this comment.
Just to confirm this works:
|
@Ehesp Thanks for your review! I've addressed the requested changes. :) |
laurenzlong
approved these changes
Oct 17, 2019
Salakar
approved these changes
Oct 19, 2019
Ehesp
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should:
languagesfield to accept a single language list;Setso that the extension doesn't translate to the same language more than once;