-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fcm): Added support for specifying analytics label in notifications #89
feat(fcm): Added support for specifying analytics label in notifications #89
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RannyRanny for putting this together. We need a couple of new types in this PR and test coverage.
…k for analytics label. Added tests.
@hiranya911 Added new classes and coveder tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RannyRanny. Looks pretty good. Just a few changes/improvements needed. Then we can merge.
FirebaseAdmin/FirebaseAdmin/Messaging/Util/AnalyticsLabelChecker.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/Util/AnalyticsLabelChecker.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/Util/AnalyticsLabelChecker.cs
Outdated
Show resolved
Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/Util/AnalyticsLabelChecker.cs
Outdated
Show resolved
Hide resolved
@hiranya911 Added requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but it looks like this needs a few more updates. The main points are:
- Add the license header to all new source files.
- Make sure there's a newline at the end of each file.
AnalyticsLabel
is optional, and therefore should allownull
.
FirebaseAdmin/FirebaseAdmin/Messaging/Util/AnalyticsLabelChecker.cs
Outdated
Show resolved
Hide resolved
@egilmorez can you look at the documentation bits of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :+1
@hiranya911 This is my first PR for open source. Can U please say when this will be available to use in NuGet package? |
@RannyRanny most likely next week. |
Solves #88