Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fcm): Added support for specifying analytics label in notifications #89

Merged
merged 6 commits into from Jul 23, 2019

Conversation

@RannyRanny
Copy link
Contributor

commented Jul 16, 2019

Solves #88

@googlebot

This comment has been minimized.

Copy link

commented Jul 16, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@RannyRanny

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Jul 16, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@hiranya911
Copy link
Member

left a comment

Thanks @RannyRanny for putting this together. We need a couple of new types in this PR and test coverage.

FirebaseAdmin/FirebaseAdmin/Messaging/ApnsConfig.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/FcmOptions.cs Outdated Show resolved Hide resolved
FirebaseAdmin/FirebaseAdmin/Messaging/FcmOptions.cs Outdated Show resolved Hide resolved
@RannyRanny

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

@hiranya911 Added new classes and coveder tests

@hiranya911
Copy link
Member

left a comment

Thanks @RannyRanny. Looks pretty good. Just a few changes/improvements needed. Then we can merge.

RannyRanny added some commits Jul 22, 2019

@RannyRanny

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

@hiranya911 Added requested changes

@hiranya911
Copy link
Member

left a comment

Sorry, but it looks like this needs a few more updates. The main points are:

  1. Add the license header to all new source files.
  2. Make sure there's a newline at the end of each file.
  3. AnalyticsLabel is optional, and therefore should allow null.
@hiranya911

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

@egilmorez can you look at the documentation bits of this PR?

@hiranya911
Copy link
Member

left a comment

LGTM :+1

@hiranya911 hiranya911 assigned hiranya911 and unassigned RannyRanny Jul 23, 2019

@hiranya911 hiranya911 merged commit 48659aa into firebase:master Jul 23, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RannyRanny

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

@hiranya911 This is my first PR for open source. Can U please say when this will be available to use in NuGet package?

@hiranya911

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

@RannyRanny most likely next week.

@hiranya911 hiranya911 changed the title Added support for analytics_label feat(fcm): Added support for specifying analytics label in notifications Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.