Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fcmOptions in WebpushConfig #185

Merged
merged 10 commits into from Nov 13, 2018
Merged

add fcmOptions in WebpushConfig #185

merged 10 commits into from Nov 13, 2018

Conversation

@chemidy
Copy link
Contributor

@chemidy chemidy commented Oct 23, 2018

new option in webpushconfig
#182

@chemidy
Copy link
Contributor Author

@chemidy chemidy commented Oct 23, 2018

GO 1.7 and 1.8 is no longer supported by lint : golang/lint#420

Maybe we have to disable it on travis for older version ?

Loading

@chemidy
Copy link
Contributor Author

@chemidy chemidy commented Oct 23, 2018

Formatting has changed on go 1.11 check an exemple here : golang/go@542ea5a

So formatting has changed

  •   "to": "/topics/test-topic",
    
  •   "to":                  "/topics/test-topic",
    

this is why the build failed

Loading

@mmermerkaya mmermerkaya requested a review from hiranya911 Oct 25, 2018
@chemidy
Copy link
Contributor Author

@chemidy chemidy commented Oct 26, 2018

Maybe we can just gofmt ( ./.travis.gofmt.sh) for go >= 1.11 due to incompatible changes

Loading

@hiranya911 hiranya911 self-assigned this Nov 13, 2018
@hiranya911
Copy link
Member

@hiranya911 hiranya911 commented Nov 13, 2018

We currently don't test on go 1.11 so I think we can ignore the gofmt issue for now.

Loading

Copy link
Member

@hiranya911 hiranya911 left a comment

Thanks @chemidy for the PR, and sorry for not replying earlier. A couple of changes pointed out for your attention.

Loading

.travis.yml Outdated Show resolved Hide resolved
Loading
messaging/messaging.go Outdated Show resolved Hide resolved
Loading
@chemidy chemidy changed the title add fcm_options in WebpushConfig add fcmOptions in WebpushConfig Nov 13, 2018
Copy link
Member

@hiranya911 hiranya911 left a comment

LGTM. Thanks @chemidy :)

Loading

@hiranya911 hiranya911 changed the base branch from master to dev Nov 13, 2018
@hiranya911 hiranya911 merged commit a75b859 into firebase:dev Nov 13, 2018
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants