Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fcmOptions in WebpushConfig #185

Merged
merged 10 commits into from Nov 13, 2018

Conversation

@chemidy
Copy link
Contributor

commented Oct 23, 2018

new option in webpushconfig
#182

chemidy added 3 commits Oct 23, 2018
@chemidy

This comment has been minimized.

Copy link
Contributor Author

commented Oct 23, 2018

GO 1.7 and 1.8 is no longer supported by lint : golang/lint#420

Maybe we have to disable it on travis for older version ?

@chemidy

This comment has been minimized.

Copy link
Contributor Author

commented Oct 23, 2018

Formatting has changed on go 1.11 check an exemple here : golang/go@542ea5a

So formatting has changed

  •   "to": "/topics/test-topic",
    
  •   "to":                  "/topics/test-topic",
    

this is why the build failed

chemidy added 2 commits Oct 24, 2018

@mmermerkaya mmermerkaya requested a review from hiranya911 Oct 25, 2018

@chemidy

This comment has been minimized.

Copy link
Contributor Author

commented Oct 26, 2018

Maybe we can just gofmt ( ./.travis.gofmt.sh) for go >= 1.11 due to incompatible changes

@hiranya911 hiranya911 self-assigned this Nov 13, 2018

@hiranya911

This comment has been minimized.

Copy link
Member

commented Nov 13, 2018

We currently don't test on go 1.11 so I think we can ignore the gofmt issue for now.

@hiranya911
Copy link
Member

left a comment

Thanks @chemidy for the PR, and sorry for not replying earlier. A couple of changes pointed out for your attention.

.travis.yml Outdated Show resolved Hide resolved
messaging/messaging.go Outdated Show resolved Hide resolved
chemidy added 4 commits Nov 13, 2018

@chemidy chemidy changed the title add fcm_options in WebpushConfig add fcmOptions in WebpushConfig Nov 13, 2018

@hiranya911
Copy link
Member

left a comment

LGTM. Thanks @chemidy :)

@hiranya911 hiranya911 changed the base branch from master to dev Nov 13, 2018

@hiranya911 hiranya911 merged commit a75b859 into firebase:dev Nov 13, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.