Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subtitle in messaging.ApsAlert payload #393

Merged
merged 3 commits into from Nov 27, 2018
Merged

add subtitle in messaging.ApsAlert payload #393

merged 3 commits into from Nov 27, 2018

Conversation

@chemidy
Copy link
Contributor

@chemidy chemidy commented Nov 21, 2018

Add subtitle field in ApsAlert payload + tests

Copy link
Member

@hiranya911 hiranya911 left a comment

Looks good. Just one change suggested.

Loading

src/messaging/messaging.ts Outdated Show resolved Hide resolved
Loading
@hiranya911 hiranya911 self-assigned this Nov 21, 2018
Copy link
Member

@hiranya911 hiranya911 left a comment

LGTM

Loading

@hiranya911 hiranya911 merged commit 48ac9d5 into firebase:master Nov 27, 2018
2 checks passed
Loading
@chemidy chemidy deleted the aps-subtitle branch Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants