Skip to content

Commit

Permalink
Wrap 2nd gen onCall functions with trace context (#1491)
Browse files Browse the repository at this point in the history
* wrap oncall functions with trace context
  • Loading branch information
blidd-google authored Nov 28, 2023
1 parent 414ff0a commit a64fd48
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Wrap 2nd gen onCall functions with trace context. (#1491)
4 changes: 3 additions & 1 deletion src/v2/providers/https.ts
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ export function onCall<T = any, Return = any | Promise<any>>(
// onCallHandler sniffs the function length to determine which API to present.
// fix the length to prevent api versions from being mismatched.
const fixedLen = (req: CallableRequest<T>) => handler(req);
const func: any = onCallHandler(
let func: any = onCallHandler(
{
cors: { origin, methods: "POST" },
enforceAppCheck: opts.enforceAppCheck ?? options.getGlobalOptions().enforceAppCheck,
Expand All @@ -375,6 +375,8 @@ export function onCall<T = any, Return = any | Promise<any>>(
fixedLen
);

func = wrapTraceContext(func);

Object.defineProperty(func, "__trigger", {
get: () => {
const baseOpts = options.optionsToTriggerAnnotations(options.getGlobalOptions());
Expand Down

0 comments on commit a64fd48

Please sign in to comment.