Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFA Integration Testing fixes #12223

Merged
merged 4 commits into from
Dec 28, 2023
Merged

MFA Integration Testing fixes #12223

merged 4 commits into from
Dec 28, 2023

Conversation

paulb777
Copy link
Member

Fix four issues integration testing Multi-Factor Authentication thanks to the test case from #11079

  • Build issue from using withCompletion: instead of completion: in some APIs
  • Created an AuthMFAResponse protocol for responses that need AuthBackend's checking of MFA error throwing
  • Fixed the type of MultiFactorInfo hint arrays. They should be PhoneMultiFactorInfo and TOTPMultiFactorInfo instead of the common base type.
  • Fixed a logic error in PhoneAuthProvider.swift: idToken can be non-nil for both the recaptcha and credential cases.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 merged commit 9a7b79d into auth-swift Dec 28, 2023
48 checks passed
@paulb777 paulb777 deleted the pb-mfa-fixes branch December 28, 2023 16:56
@firebase firebase locked and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants