-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FCM and InstanceID compatible with tvOS #2428
Conversation
A few more things I noticed trying to run in the branch:
|
There's conflict in the file, should I keep adding IID tests and merge later or just submit this CL first? |
The conflict needs to be solved before merging. It looks feasible now after deintegrating. At a quick glance, it looks like "Accepting Both" for the one conflict will do it. Also, the new test targets should be added to the "All tvOS" Aggregate target scheme and then they'll be included in CI. |
Do |
Done merging the conflicts. |
It doesn't let me merge by running git merge origin/master |
Looks like we need to update the FirebaseInstanceID version on SpecsStaging for FirebaseMessaging to pass To be safe, let's hold off on this until the M44 release branch gets made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when travis is green
A follow up PR should add IID and tvOS unit tests
No description provided.