Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving FIRAnalyticsConfiguration calls to Analytics. #2516

Merged
merged 5 commits into from Mar 13, 2019

Conversation

@ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented Mar 11, 2019

These APIS are specific to the Analytics SDK and have been moved there.
The instance methods have become static methods on the FIRAnalytics
class.

Should not be submitted until the internal Analytics changes land.

These APIS are specific to the Analytics SDK and have been moved there.
The instance methods have become static methods on the `FIRAnalytics`
class.
@ryanwilson ryanwilson added this to the M45 milestone Mar 11, 2019
@ryanwilson ryanwilson requested a review from paulb777 Mar 11, 2019
@ryanwilson
Copy link
Member Author

@ryanwilson ryanwilson commented Mar 12, 2019

This is the first half of #1785 - the second half is removing it entirely.

@ryanwilson
Copy link
Member Author

@ryanwilson ryanwilson commented Mar 13, 2019

Submitting since Travis is just running on the CHANGELOG change.

@ryanwilson ryanwilson merged commit 7cbd945 into master Mar 13, 2019
1 of 2 checks passed
@ryanwilson ryanwilson deleted the rw-deprecate-core-apis branch Mar 13, 2019
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants