Remove unnecessary Core private headers #6439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwilson
reviewed
Sep 11, 2020
| @@ -110,7 +104,7 @@ extern NSString *const FIRAuthStateDidChangeInternalNotificationUIDKey; | |||
| * FIRApp notification listener. | |||
| */ | |||
| + (NSError *)errorForSubspecConfigurationFailureWithDomain:(NSString *)domain | |||
There was a problem hiding this comment.
This method is only used once in FDL and once in RC - think it's worth keeping it in Core for a ~5 line implementation? Diff wise it'd probably be less LOC to just inline the implementation at both call sites, and cleans up Core.
ryanwilson
approved these changes
Sep 14, 2020
Comment on lines
188
to
191
| error = [self errorForSubspecConfigurationFailureWithDomain:kFirebaseDurableDeepLinkErrorDomain | ||
| errorCode:FIRErrorCodeDurableDeepLinkFailed | ||
| service:@"DynamicLinks" | ||
| reason:errorDescription]; |
There was a problem hiding this comment.
Since this call is only used once and it's the same number of lines, I think this could even be inlined.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3777
#no-changelog