Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a rare RC crash #6556

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Fix a rare RC crash #6556

merged 2 commits into from
Sep 24, 2020

Conversation

paulb777
Copy link
Member

Fix #6522

Even though [error localizedDescription] is never supposed to return nil, it seems that it sometime does. See https://stackoverflow.com/a/34684861/556617.

This change avoids a crash when that happens.

@paulb777 paulb777 added this to the 6.34.0 - M81 milestone Sep 24, 2020
@paulb777
Copy link
Member Author

cc: @karenyz

@paulb777 paulb777 merged commit f8b6e8f into master Sep 24, 2020
@paulb777 paulb777 deleted the pb-fix-rc-crash branch September 24, 2020 16:01
christibbs pushed a commit that referenced this pull request Sep 28, 2020
@firebase firebase locked and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Exception: NSInvalidArgumentException
4 participants