Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly specify the default constructor to FieldPath #773

Merged
merged 2 commits into from
Feb 8, 2018
Merged

Explicitly specify the default constructor to FieldPath #773

merged 2 commits into from
Feb 8, 2018

Commits on Feb 8, 2018

  1. Explicitly specify the default constructor to FieldPath 

    Xcode prior to 8.3 does not accept an explicitly defaulted constructor
(`= default`) for the purposes of default initializing a const object.

This fixes a build failure under Xcode 8.2:

Firestore/core/src/firebase/firestore/model/field_path.cc:144:26: error: default initialization of an object of const type 'const firebase::firestore::model::FieldPath' without a user-provided default constructor
  static const FieldPath empty_path;
    @wilhuff
    wilhuff committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    2b19cc2 View commit details
    Browse the repository at this point in the history

  2. Fix style

    @paulb777
    paulb777 committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    bf074c0 View commit details
    Browse the repository at this point in the history