Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[database] FIREBASE WARNING: Invalid query string segment: #517

Closed
jc275 opened this issue Feb 16, 2018 · 48 comments · Fixed by #518
Closed

[database] FIREBASE WARNING: Invalid query string segment: #517

jc275 opened this issue Feb 16, 2018 · 48 comments · Fixed by #518

Comments

@jc275
Copy link

jc275 commented Feb 16, 2018

warn('Invalid query string segment: ' + segment);

@tonymeng This warning now appears during firebase.initializeApp(config) even where config.databaseURL does not include any ns query parameter.

@google-oss-bot
Copy link
Contributor

Hey there! I couldn't figure out what this issue is about, so I've labeled it for a human to triage. Hang tight.

@google-oss-bot
Copy link
Contributor

Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.

@jc275 jc275 changed the title FIREBASE WARNING: Invalid query string segment: [database] FIREBASE WARNING: Invalid query string segment: Feb 16, 2018
@tonymeng
Copy link
Contributor

I'll take a look

@benoj
Copy link

benoj commented Feb 17, 2018

I have been seeing this too - the query has been running extremely slowly too. Could this be the cause of the slowdown?

The query is

admin.database().ref(`careers/listing-content/${organisation}`).once("value")

and the data in this query only contains 800bytes of data but is taking over 2 seconds to return?

@Zjaaspoer
Copy link

the query has been running extremely slowly too

seeing this too unfortunately

@ysk8
Copy link

ysk8 commented Feb 17, 2018

screen shot 2018-02-17 at 10 57 22

I just get this too, but the info about the Warning is incomplete. The function run well, but there is some delay compeers to the nominal speed of Firebase.

@harsh183
Copy link

I've been getting this for a bit too on my server. What seems to be causing this? It also seems to cause some slowdowns as well.

@mrgoodrich
Copy link

+1

1 similar comment
@Ashok-Varma
Copy link

+1

@sejr
Copy link

sejr commented Feb 18, 2018

+1 😦

@mrgoodrich
Copy link

mrgoodrich commented Feb 18, 2018

I'm a Software Developer at Google and submitted another issue to investigate this problem a few hours ago. Sorry about the frustration, I wish I was familiar with this domain, and it probably won't help to submit more reports fyi. While a fix may have been made, it might not be present in npm or could have not actually fixed the problem. I will also consider contacting @tonymeng (made a change earlier) tomorrow if we don't hear a response, since this seems significant.

@ayushmittal
Copy link

+1

@mrgoodrich
Copy link

mrgoodrich commented Feb 18, 2018

After talking with support this doesn't seem as serious as I thought. The message is just a warning and "shouldn't have any impacts on the function's overall processing." I thought it was preventing changes to functions, but after viewing the function source in the Cloud Console I see the deployments still succeed. I'll keep you updated if I learn anything else. The fix has not been released, but it has been made.

@harsh183
Copy link

All my functions seem to work fine, and it was not preventing that. This is not a critical bug, but it creates a lot of high level warnings that drown out the other logs.

@kleeb
Copy link

kleeb commented Feb 18, 2018

+1

@mrgoodrich
Copy link

My functions are working again and I was just unlucky with experiencing another problem causing my functions to fail at the exact same time as this warning.

For anyone wanting to remove the warning, in case it has other associated problems, you can force a dependency of "@firebase/database": 0.1.9. I tested this earlier. Also, if they choose to add the bug fix to the next release, I assume 0.1.11+ will not have the warning.

@dmurawsky
Copy link

+1

1 similar comment
@marudits
Copy link

+1

@egr-ext
Copy link

egr-ext commented Feb 19, 2018

Hi, thanks for the support. Is the solution would be to configure the functions/package.json file like that:

{
  "name": "functions",
  "description": "Cloud Functions for Firebase",
  "dependencies": {
    "firebase-admin": "~5.8.1",
    "firebase-functions": "^0.8.1",
    "@firebase/database": 0.1.9
  },
  "private": true
}

@jemshit
Copy link

jemshit commented Feb 19, 2018

Why is this closed ? @tonymeng

@egr-ext
Copy link

egr-ext commented Feb 19, 2018

+1 I still have a lot of warning today.

@mertkahraman42
Copy link

+1

2 similar comments
@lanchana
Copy link

+1

@alexanderkhitev
Copy link

+1

@tonymeng
Copy link
Contributor

this issue has been auto-closed as the fix has been merged, it will be available in the next version of the sdk.

as for what the issue is, there's a bug in parsing the databaseURL which causes the warning to be logged every time a new connection is made. It should not impact any part of the SDK or connectivity as the query string isn't currently being used for anything.

@fethi16
Copy link

fethi16 commented Feb 20, 2018

+1

1 similar comment
@lfernando-silva
Copy link

+1

@mauricioA0
Copy link

I have the same problem.

Do you know when will fix this issue ?

Thanks

@di9it
Copy link

di9it commented Feb 20, 2018

you can ignore it until next update...

        if (parseInt(firebase.SDK_VERSION.replace('.', ''), 10) === 410) {
            console.ignoredYellowBox = ['FIREBASE WARNING: Invalid query string segment:'];
        } else {
            console.error('REMOVE ME!');
        }

@jamatsui
Copy link

+1

1 similar comment
@kclay
Copy link

kclay commented Feb 20, 2018

+1

@jshcrowthe
Copy link
Contributor

jshcrowthe commented Feb 20, 2018

Hey y'all!

Appreciate all the interest in having this resolved. As the fix has already been merged it'll be released in the next version of the SDK. If you are anxious for a workaround:

  1. Consider downgrading to @firebase/database@0.1.9, this version does not contain the bug (and the associated query param support)
  2. Look at the firebase@next package (contains the next staged release, this can fall behind a mainline branch as it is only used to stage the next release get on @latest ASAP after the version has been released)
  3. Look at the firebase@canary package (which will always contain the latest valid code).

NOTE: The NPM canary tag is experimental, if you do opt for the second workaround, make sure you get back onto a mainline release ASAP

@kleeb
Copy link

kleeb commented Feb 21, 2018

how about 0.1.11-0 ?

@jshcrowthe
Copy link
Contributor

@kleeb That will also work, that is the next staged version and wasn't released when I wrote the above comment. I'll revise it 😄

@mauriciovillalba
Copy link

Do you know when will be release the new version ?

@lemartva
Copy link

Same error here any idea?

@jernejc
Copy link

jernejc commented Feb 22, 2018

+1

3 similar comments
@salifukayta
Copy link

+1

@suenwl
Copy link

suenwl commented Feb 22, 2018

+1

@sennl
Copy link

sennl commented Feb 22, 2018

+1

@amaini
Copy link

amaini commented Feb 22, 2018

what is the command to downgarde the firebase
is it npm install --save firebase@firebase/database@0.1.9
please help

@kleeb
Copy link

kleeb commented Feb 22, 2018

0.1.11 has just been released

@kleeb
Copy link

kleeb commented Feb 22, 2018

The warning still occurs on 0.1.11 version

@jshcrowthe
Copy link
Contributor

@kleeb can you please try clean installing your dependencies. I just tested this myself and it seems to be working. The behavior I found was the following:

  • Complete database URLs, with no query params (i.e. https://<PROJECT>.firebaseio.com), do not trigger the warning
  • Complete database URLs, with a query param set to a value (i.e. https://<PROJECT>.firebaseio.com?foo=bar) do not trigger the warning
  • Complete database URLs, with a query param that is not set (https://<PROJECT>.firebaseio.com?foo) do trigger the warning (NOTE: This is intended)

@tjkang
Copy link

tjkang commented Feb 22, 2018

finally fixed it with 0.1.11 version! it removed warning for me

@mikehlee21
Copy link

Warning has gone away completely on latest version.

"dependencies": {
    "firebase-admin": "^5.9.0",
    "firebase-functions": "^0.8.1",
  },

@kleeb
Copy link

kleeb commented Feb 23, 2018

@jshcrowthe
I am always cleaning out.

I guess that firebase function cache didn't catch it minutes after the release. I redeployed right now and yes - now it is fixed. Thanks!

reidangwin added a commit to reidangwin/bloctime that referenced this issue Feb 23, 2018
      - Instance of 'class' rather than 'className' in TaskList jsx
      - Added key to the tr and nested td in the map function that renders tasks
      - Removed re-base and did a fresh install with 'yarn remove re-base', 'yarn
      add re-base'. While still functional, old version of firebase was throwing
      console errors. (see firebase/firebase-js-sdk#517)
@frdrcklopez
Copy link

first run "npm uninstall @firebase/database"
then "npm uninstall @firebase/database@0.1.8" does the trick to me :)

@firebase firebase locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.