Remove dependency on global atob/btoa functions #2677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2020 16:54
thebrianchen
assigned schmidt-sebastian and unassigned thebrianchen and schmidt-sebastian
|
@thebrianchen Can you provide some size stats for the new dependency? I would like to know what impact this has on the size of |
|
@schmidt-sebastian It's going from 318,422B to 321,001B. |
|
As discussed offline, please see if our guidance on Polyfills applies here. Please see here: https://firebase.google.com/support/guides/environments_js-sdk#polyfills |
|
Plan is to update docs with react-native polyfills to reduce SDK size. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2667
#2639 introduced use of
atobinByteString, which is causing the failure in environments where there is no globalatobfunction. This PR removes the dependency on globalatobby using our ownatobfunction when globalatobis unavailable.