Add getIdTokenResult implementation #3014
Conversation
Binary Size ReportAffected SDKsNo changes between base commit (6b951a1) and head commit (f47ba5b). Test Logs
|
| } | ||
|
|
||
| export interface ParsedToken { | ||
| [key: string]: string | ParsedToken; |
There was a problem hiding this comment.
a token can include another token?
There was a problem hiding this comment.
it can include a sub object yes
There was a problem hiding this comment.
recommend naming these differently then, ParsedToken should include standardized JWT fields on it like iat, the nested object should be a FirebaseClaims
There was a problem hiding this comment.
Done-ish
I changed the index signature (which needs to cover all named types as well) to be string|object|undefined, the firebase specific type is then covered.
| ): Promise<IdTokenResult> { | ||
| const token = await user.getIdToken(forceRefresh); | ||
| const claims = parseClaims(token); | ||
| // const firebase = claims?.firebase; |
|
|
||
| function makeJWT(claims: object): string { | ||
| const b64 = base64Encode(JSON.stringify(claims)); | ||
| return `algorithm.${b64}.signature`; |
There was a problem hiding this comment.
Alex made the point later in the review that the middle part is often called payload. It's clear that this is base64 as well. Lets be consistent with whatever you choose!
| @@ -0,0 +1,86 @@ | |||
| /** | |||
There was a problem hiding this comment.
Any of this need javadoc?
There was a problem hiding this comment.
yeah that's the license
There was a problem hiding this comment.
Snarky but I meant the code itself. I was just pointing to the top of the file
There was a problem hiding this comment.
Ooooooh I misunderstood, my b
|
|
||
| export interface ParsedToken { | ||
| 'exp'?: string; | ||
| 'auth_time'?: string; |
There was a problem hiding this comment.
looks like auth_time is not a standard field, do we always have it present? https://en.wikipedia.org/wiki/JSON_Web_Token#Standard_fields
There was a problem hiding this comment.
¯\_(ツ)_/¯ I'm just copying what the js version does. It's marked as ?: optional so no it's not necessarily always there, that's why we do the assert
No description provided.