Make Analytics environment checks warnings instead of errors #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8bbcdb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
Feiyang1
suggested changes
Sep 24, 2020
packages/analytics/src/factory.ts
Outdated
| installations, | ||
| gtagCoreFunction | ||
| ); | ||
| initializationPromisesMap[appId] = validateIndexedDBOpenable() |
There was a problem hiding this comment.
It seems we can combine the sync checks with the async check here so that we don't need to return an empty instance, and no-op happens in the original methods.
packages/analytics/src/factory.ts
Outdated
| gtagCoreFunction | ||
| ) | ||
| ) | ||
| .catch(e => { |
There was a problem hiding this comment.
Should put the catch directly behind the environment check promise, otherwise we are catching errors from initializeIds as well
There was a problem hiding this comment.
We can have a single environment check error which lists all the failed conditions.
packages/analytics/src/functions.ts
Outdated
| @@ -41,7 +57,12 @@ export async function logEvent( | |||
| gtagFunction(GtagCommand.EVENT, eventName, eventParams); | |||
| return; | |||
| } else { | |||
| const measurementId = await initializationPromise; | |||
| const measurementId = await handleInitializationPromiseErrors( | |||
There was a problem hiding this comment.
We are using measurementId for the result of environment checks. A cleaner way might be wrapping the whole function in a try catch, so it's a no-op if anything failed in initialization. You will need to re-throw the errors where we currently log the error messages.
There was a problem hiding this comment.
I wasn't totally sure what you meant but I tried to do this.
There was a problem hiding this comment.
Sorry I was not clear. The code looks like that we are doing no-op because measurementId is not available, but in fact it could be that it is available, but the environment check failed, so it is confusing to readers. I think we should make it clear in the code that we do no-op when either environment check fails or measurementId is not available.
packages/analytics/src/helpers.ts
Outdated
| @@ -166,6 +173,12 @@ async function gtagOnEvent( | |||
| // Workaround for http://b/141370449 - third argument cannot be undefined. | |||
| gtagCore(GtagCommand.EVENT, measurementId, gtagParams || {}); | |||
There was a problem hiding this comment.
It is out of scope of this PR, but we should move the gtagCore call outside of the try catch block. It should execute regardless if our initialization failed or not. The current implementation will prevent people from sending events to a non-firebase managed measurementId if any of our initialization failed.
There was a problem hiding this comment.
Another problem is we can not use Promise.all to wait for all promises, because it will reject if any of the promises was rejected. (Sorry I didn't catch it before!).
Instead, we should use Promise.allSettled which is part of es2020 which is too new to use directly. There is an easy polyfill we can do before putting the promises into initializationPromisesMap and dynamicConfigPromisesList (and other promise maps where we do Promise.all), like so:
function reflect(promise){
return promise.then(function(v){ return {v:v, status: "fulfilled" }},
function(e){ return {e:e, status: "rejected" }});
}
initializationPromisesMap[appId] = reflect(initializeIds(\*...*\));
There was a problem hiding this comment.
We should resolve the above issues in a separate PR.
Size Analysis ReportAffected Products
|
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.63 kB | ? (?) |
| size_with_ext_deps | ? | 4.05 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | _addComponent_registerComponentisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 22 depsERRORSERROR_FACTORYPLATFORM_LOG_STRINGSDK_VERSION_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversionversion$1 |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
_DEFAULT_ENTRY_NAME
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.63 kB | ? (?) |
| size_with_ext_deps | ? | 4.05 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | _addComponent_registerComponentisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 21 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_DEFAULT_ENTRY_NAME_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
_addComponent
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.61 kB | ? (?) |
| size_with_ext_deps | ? | 4.02 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | _addComponent_registerComponentisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
_addOrOverwriteComponent
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.67 kB | ? (?) |
| size_with_ext_deps | ? | 4.09 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | Click to show 6 deps_addComponent_addOrOverwriteComponent_registerComponentisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
_apps
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.60 kB | ? (?) |
| size_with_ext_deps | ? | 4.02 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | _addComponent_registerComponentisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
_clearComponents
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.63 kB | ? (?) |
| size_with_ext_deps | ? | 4.05 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | Click to show 6 deps_addComponent_clearComponents_registerComponentisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
_components
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.61 kB | ? (?) |
| size_with_ext_deps | ? | 4.02 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | _addComponent_registerComponentisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
_getProvider
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.66 kB | ? (?) |
| size_with_ext_deps | ? | 4.07 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | Click to show 6 deps_addComponent_getProvider_registerComponentisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
_registerComponent
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.61 kB | ? (?) |
| size_with_ext_deps | ? | 4.03 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | _addComponent_registerComponentisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
_removeServiceInstance
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.73 kB | ? (?) |
| size_with_ext_deps | ? | 4.15 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | Click to show 7 deps_addComponent_getProvider_registerComponent_removeServiceInstanceisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 21 depsDEFAULT_ENTRY_NAMEERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
deleteApp
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.75 kB | ? (?) |
| size_with_ext_deps | ? | 4.16 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | Click to show 6 deps_addComponent_registerComponentdeleteAppisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
getApp
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.71 kB | ? (?) |
| size_with_ext_deps | ? | 5.39 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | Click to show 6 deps_addComponent_registerComponentgetAppisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 21 depsDEFAULT_ENTRY_NAMEERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
getApps
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.64 kB | ? (?) |
| size_with_ext_deps | ? | 4.06 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | Click to show 6 deps_addComponent_registerComponentgetAppsisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
initializeApp
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 3.69 kB | ? (?) |
| size_with_ext_deps | ? | 9.05 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | Click to show 6 deps_addComponent_registerComponentinitializeAppisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | FirebaseAppImplPlatformLoggerService |
? |
| variables | ? | Click to show 21 depsDEFAULT_ENTRY_NAMEERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | ComponentComponentContainer |
? |
onLog
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.74 kB | ? (?) |
| size_with_ext_deps | ? | 5.95 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | Click to show 6 deps_addComponent_registerComponentisVersionServiceProvideronLogregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | LoggersetUserLogHandler |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
registerVersion
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.61 kB | ? (?) |
| size_with_ext_deps | ? | 4.03 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | _addComponent_registerComponentisVersionServiceProviderregisterCoreComponentsregisterVersion |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | Logger |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
setLogLevel
Size
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| size | ? | 2.64 kB | ? (?) |
| size_with_ext_deps | ? | 4.11 kB | ? (?) |
Dependencies
| Type | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
| functions | ? | Click to show 6 deps_addComponent_registerComponentisVersionServiceProviderregisterCoreComponentsregisterVersionsetLogLevel |
? |
| classes | ? | PlatformLoggerService |
? |
| variables | ? | Click to show 20 depsERRORSERROR_FACTORYPLATFORM_LOG_STRING_apps_componentsloggername$1name$2name$3name$4name$5name$6name$7name$8name$9name$aname$bname$cname$dversion |
? |
External Dependencies
| Module | Base (0c607c9) | Head (5c8621f) | Diff |
|---|---|---|---|
@firebase/logger |
? | LoggersetLogLevel |
? |
@firebase/util |
? | ErrorFactory |
? |
@firebase/component |
? | Component |
? |
@firebase/functions-exp
-
getFunctionsSize
Type Base (0c607c9) Head (5c8621f) Diff size ? 1.98 kB ? (?) size_with_ext_deps ? 5.86 kB ? (?) Dependencies
Type Base (0c607c9) Head (5c8621f) Diff functions ? getFunctionsregisterFunctions? classes ? ContextProviderFunctionsService? variables ? DEFAULT_REGIONFUNCTIONS_TYPEnameversion? External Dependencies
Module Base (0c607c9) Head (5c8621f) Diff @firebase/app-exp? _getProvider_registerComponentregisterVersion? @firebase/component? Component? -
httpsCallableSize
Type Base (0c607c9) Head (5c8621f) Diff size ? 5.33 kB ? (?) size_with_ext_deps ? 9.92 kB ? (?) Dependencies
Type Base (0c607c9) Head (5c8621f) Diff functions ? Click to show 10 deps
_errorForResponsecallcodeForHTTPStatusdecodeencodefailAfterhttpsCallablemapValuespostJSONregisterFunctions? classes ? ContextProviderFunctionsErrorFunctionsService? variables ? Click to show 7 deps
DEFAULT_REGIONFUNCTIONS_TYPELONG_TYPEUNSIGNED_LONG_TYPEerrorCodeMapnameversion? External Dependencies
Module Base (0c607c9) Head (5c8621f) Diff @firebase/util? FirebaseError? @firebase/app-exp? _registerComponentregisterVersion? @firebase/component? Component? -
useFunctionsEmulatorSize
Type Base (0c607c9) Head (5c8621f) Diff size ? 1.94 kB ? (?) size_with_ext_deps ? 5.79 kB ? (?) Dependencies
Type Base (0c607c9) Head (5c8621f) Diff functions ? registerFunctionsuseFunctionsEmulator? classes ? ContextProviderFunctionsService? variables ? DEFAULT_REGIONFUNCTIONS_TYPEnameversion? External Dependencies
Module Base (0c607c9) Head (5c8621f) Diff @firebase/app-exp? _registerComponentregisterVersion? @firebase/component? Component?
@firebase/installations-exp
-
deleteInstallationsSize
Type Base (0c607c9) Head (5c8621f) Diff size ? 8.90 kB ? (?) size_with_ext_deps ? 17.3 kB ? (?) Dependencies
Type Base (0c607c9) Head (5c8621f) Diff functions ? Click to show 52 deps
broadcastFidChangebufferToBase64UrlSafecallFidChangeCallbacksclearTimedOutRequestcloseBroadcastChannelcompleteInstallationRegistrationcreateInstallationRequestdeleteInstallationRequestdeleteInstallationsencodeextractAppConfigextractAuthTokenInfoFromResponsefetchAuthTokenFromServerfidChangedgenerateAuthTokenRequestgenerateFidgetAuthorizationHeadergetBroadcastChannelgetDbPromisegetDeleteEndpointgetErrorFromResponsegetExpiresInFromResponseExpiresIngetGenerateAuthTokenEndpointgetHeadersgetHeadersWithAuthgetIdgetInstallationEntrygetInstallationsEndpointgetKeygetMissingValueErrorgetTokenhasAuthTokenRequestTimedOuthasInstallationRequestTimedOutisAuthTokenExpiredisAuthTokenValidisEntryRegisteredisServerErrormakeAuthTokenRequestInProgressEntryrefreshAuthTokenregisterInstallationregisterInstallationsremoveretryIfServerErrorsetsleeptriggerRegistrationIfNecessaryupdateupdateAuthTokenRequestupdateInstallationRequestupdateOrCreateInstallationEntrywaitUntilAuthTokenRequestwaitUntilFidRegistration? variables ? Click to show 23 deps
DATABASE_NAMEDATABASE_VERSIONERROR_DESCRIPTION_MAPERROR_FACTORYINSTALLATIONS_API_URLINSTALLATIONS_NAMEINSTALLATIONS_NAME_INTERNALINTERNAL_AUTH_VERSIONINVALID_FIDOBJECT_STORE_NAMEPACKAGE_VERSIONPENDING_TIMEOUT_MSSERVICESERVICE_NAMETOKEN_EXPIRATION_BUFFERVALID_FID_PATTERNbroadcastChanneldbPromisefidChangeCallbacksinternalFactorynamepublicFactoryversion? External Dependencies
Module Base (0c607c9) Head (5c8621f) Diff @firebase/util? ErrorFactoryFirebaseError? idb? openDb? @firebase/app-exp? _getProvider_registerComponentregisterVersion? @firebase/component? Component? -
getIdSize
Type Base (0c607c9) Head (5c8621f) Diff size ? 8.34 kB ? (?) size_with_ext_deps ? 16.8 kB ? (?) Dependencies
Type Base (0c607c9) Head (5c8621f) Diff functions ? Click to show 49 deps
broadcastFidChangebufferToBase64UrlSafecallFidChangeCallbacksclearTimedOutRequestcloseBroadcastChannelcompleteInstallationRegistrationcreateInstallationRequestencodeextractAppConfigextractAuthTokenInfoFromResponsefetchAuthTokenFromServerfidChangedgenerateAuthTokenRequestgenerateFidgetAuthorizationHeadergetBroadcastChannelgetDbPromisegetErrorFromResponsegetExpiresInFromResponseExpiresIngetGenerateAuthTokenEndpointgetHeadersgetHeadersWithAuthgetIdgetInstallationEntrygetInstallationsEndpointgetKeygetMissingValueErrorgetTokenhasAuthTokenRequestTimedOuthasInstallationRequestTimedOutisAuthTokenExpiredisAuthTokenValidisEntryRegisteredisServerErrormakeAuthTokenRequestInProgressEntryrefreshAuthTokenregisterInstallationregisterInstallationsremoveretryIfServerErrorsetsleeptriggerRegistrationIfNecessaryupdateupdateAuthTokenRequestupdateInstallationRequestupdateOrCreateInstallationEntrywaitUntilAuthTokenRequestwaitUntilFidRegistration? variables ? Click to show 23 deps
DATABASE_NAMEDATABASE_VERSIONERROR_DESCRIPTION_MAPERROR_FACTORYINSTALLATIONS_API_URLINSTALLATIONS_NAMEINSTALLATIONS_NAME_INTERNALINTERNAL_AUTH_VERSIONINVALID_FIDOBJECT_STORE_NAMEPACKAGE_VERSIONPENDING_TIMEOUT_MSSERVICESERVICE_NAMETOKEN_EXPIRATION_BUFFERVALID_FID_PATTERNbroadcastChanneldbPromisefidChangeCallbacksinternalFactorynamepublicFactoryversion? External Dependencies
Module Base (0c607c9) Head (5c8621f) Diff @firebase/util? ErrorFactoryFirebaseError? idb? openDb? @firebase/app-exp? _getProvider_registerComponentregisterVersion? @firebase/component? Component? -
getInstallationsSize
Type Base (0c607c9) Head (5c8621f) Diff size ? 8.43 kB ? (?) size_with_ext_deps ? 16.9 kB ? (?) Dependencies
Type Base (0c607c9) Head (5c8621f) Diff functions ? Click to show 50 deps
broadcastFidChangebufferToBase64UrlSafecallFidChangeCallbacksclearTimedOutRequestcloseBroadcastChannelcompleteInstallationRegistrationcreateInstallationRequestencodeextractAppConfigextractAuthTokenInfoFromResponsefetchAuthTokenFromServerfidChangedgenerateAuthTokenRequestgenerateFidgetAuthorizationHeadergetBroadcastChannelgetDbPromisegetErrorFromResponsegetExpiresInFromResponseExpiresIngetGenerateAuthTokenEndpointgetHeadersgetHeadersWithAuthgetIdgetInstallationEntrygetInstallationsgetInstallationsEndpointgetKeygetMissingValueErrorgetTokenhasAuthTokenRequestTimedOuthasInstallationRequestTimedOutisAuthTokenExpiredisAuthTokenValidisEntryRegisteredisServerErrormakeAuthTokenRequestInProgressEntryrefreshAuthTokenregisterInstallationregisterInstallationsremoveretryIfServerErrorsetsleeptriggerRegistrationIfNecessaryupdateupdateAuthTokenRequestupdateInstallationRequestupdateOrCreateInstallationEntrywaitUntilAuthTokenRequestwaitUntilFidRegistration? variables ? Click to show 23 deps
DATABASE_NAMEDATABASE_VERSIONERROR_DESCRIPTION_MAPERROR_FACTORYINSTALLATIONS_API_URLINSTALLATIONS_NAMEINSTALLATIONS_NAME_INTERNALINTERNAL_AUTH_VERSIONINVALID_FIDOBJECT_STORE_NAMEPACKAGE_VERSIONPENDING_TIMEOUT_MSSERVICESERVICE_NAMETOKEN_EXPIRATION_BUFFERVALID_FID_PATTERNbroadcastChanneldbPromisefidChangeCallbacksinternalFactorynamepublicFactoryversion? External Dependencies
Module Base (0c607c9) Head (5c8621f) Diff @firebase/util? ErrorFactoryFirebaseError? idb? openDb? @firebase/app-exp? _getProvider_registerComponentregisterVersion? @firebase/component? Component? -
getTokenSize
Type Base (0c607c9) Head (5c8621f) Diff size ? 8.35 kB ? (?) size_with_ext_deps ? 16.8 kB ? (?) Dependencies
Type Base (0c607c9) Head (5c8621f) Diff functions ? Click to show 49 deps
broadcastFidChangebufferToBase64UrlSafecallFidChangeCallbacksclearTimedOutRequestcloseBroadcastChannelcompleteInstallationRegistrationcreateInstallationRequestencodeextractAppConfigextractAuthTokenInfoFromResponsefetchAuthTokenFromServerfidChangedgenerateAuthTokenRequestgenerateFidgetAuthorizationHeadergetBroadcastChannelgetDbPromisegetErrorFromResponsegetExpiresInFromResponseExpiresIngetGenerateAuthTokenEndpointgetHeadersgetHeadersWithAuthgetIdgetInstallationEntrygetInstallationsEndpointgetKeygetMissingValueErrorgetTokenhasAuthTokenRequestTimedOuthasInstallationRequestTimedOutisAuthTokenExpiredisAuthTokenValidisEntryRegisteredisServerErrormakeAuthTokenRequestInProgressEntryrefreshAuthTokenregisterInstallationregisterInstallationsremoveretryIfServerErrorsetsleeptriggerRegistrationIfNecessaryupdateupdateAuthTokenRequestupdateInstallationRequestupdateOrCreateInstallationEntrywaitUntilAuthTokenRequestwaitUntilFidRegistration? variables ? Click to show 23 deps
DATABASE_NAMEDATABASE_VERSIONERROR_DESCRIPTION_MAPERROR_FACTORYINSTALLATIONS_API_URLINSTALLATIONS_NAMEINSTALLATIONS_NAME_INTERNALINTERNAL_AUTH_VERSIONINVALID_FIDOBJECT_STORE_NAMEPACKAGE_VERSIONPENDING_TIMEOUT_MSSERVICESERVICE_NAMETOKEN_EXPIRATION_BUFFERVALID_FID_PATTERNbroadcastChanneldbPromisefidChangeCallbacksinternalFactorynamepublicFactoryversion? External Dependencies
Module Base (0c607c9) Head (5c8621f) Diff @firebase/util? ErrorFactoryFirebaseError? idb? openDb? @firebase/app-exp? _getProvider_registerComponentregisterVersion? @firebase/component? Component? -
onIdChangeSize
Type Base (0c607c9) Head (5c8621f) Diff size ? 8.60 kB ? (?) size_with_ext_deps ? 17.0 kB ? (?) Dependencies
Type Base (0c607c9) Head (5c8621f) Diff functions ? Click to show 52 deps
addCallbackbroadcastFidChangebufferToBase64UrlSafecallFidChangeCallbacksclearTimedOutRequestcloseBroadcastChannelcompleteInstallationRegistrationcreateInstallationRequestencodeextractAppConfigextractAuthTokenInfoFromResponsefetchAuthTokenFromServerfidChangedgenerateAuthTokenRequestgenerateFidgetAuthorizationHeadergetBroadcastChannelgetDbPromisegetErrorFromResponsegetExpiresInFromResponseExpiresIngetGenerateAuthTokenEndpointgetHeadersgetHeadersWithAuthgetIdgetInstallationEntrygetInstallationsEndpointgetKeygetMissingValueErrorgetTokenhasAuthTokenRequestTimedOuthasInstallationRequestTimedOutisAuthTokenExpiredisAuthTokenValidisEntryRegisteredisServerErrormakeAuthTokenRequestInProgressEntryonIdChangerefreshAuthTokenregisterInstallationregisterInstallationsremoveremoveCallbackretryIfServerErrorsetsleeptriggerRegistrationIfNecessaryupdateupdateAuthTokenRequestupdateInstallationRequestupdateOrCreateInstallationEntrywaitUntilAuthTokenRequestwaitUntilFidRegistration? variables ? Click to show 23 deps
DATABASE_NAMEDATABASE_VERSIONERROR_DESCRIPTION_MAPERROR_FACTORYINSTALLATIONS_API_URLINSTALLATIONS_NAMEINSTALLATIONS_NAME_INTERNALINTERNAL_AUTH_VERSIONINVALID_FIDOBJECT_STORE_NAMEPACKAGE_VERSIONPENDING_TIMEOUT_MSSERVICESERVICE_NAMETOKEN_EXPIRATION_BUFFERVALID_FID_PATTERNbroadcastChanneldbPromisefidChangeCallbacksinternalFactorynamepublicFactoryversion? External Dependencies
Module Base (0c607c9) Head (5c8621f) Diff @firebase/util? ErrorFactoryFirebaseError? idb? openDb? @firebase/app-exp? _getProvider_registerComponentregisterVersion? @firebase/component? Component?
@firebase/performance-exp
-
getPerformanceSize
Type Base (0c607c9) Head (5c8621f) Diff size ? 16.8 kB ? (?) size_with_ext_deps ? 21.8 kB ? (?) Dependencies
Type Base (0c607c9) Head (5c8621f) Diff functions ? Click to show 50 deps
addToQueuechangeInitializationStatusconfigValidconvertMetricValueToIntegercreateNetworkRequestEntrycreateUserTimingTracedispatchQueueEventsgetApiKeygetAppIdgetApplicationInfogetAuthTokenPromisegetConfiggetDocumentReadyCompletegetEffectiveConnectionTypegetIidgetIidPromisegetInitializationPromisegetPerformancegetProjectIdgetRemoteConfiggetServiceWorkerStatusgetStoredConfiggetVisibilityStateinitializePerfisPerfInitializedisValidCustomAttributeNameisValidCustomAttributeValueisValidMetricNamelogNetworkRequestlogTracemergeStringspostToFlEndpointprocessConfigprocessQueueregisterPerformancesendEventsToFlsendLogsendTraceLogserializeNetworkRequestserializeTraceserializersetupApisetupNetworkRequestssetupOobResourcessetupOobTracessetupTransportServicesetupUserTimingTracesshouldLogAfterSamplingstoreConfigtransportHandler? classes ? ApiPerformanceControllerSettingsServiceTrace? variables ? Click to show 45 deps
ATTRIBUTE_FORMAT_REGEXCONFIG_EXPIRY_LOCAL_STORAGE_KEYCONFIG_LOCAL_STORAGE_KEYCOULD_NOT_GET_CONFIG_MSGDEFAULT_CONFIGSDEFAULT_ENTRY_NAMEDEFAULT_REMAINING_TRIESDEFAULT_SEND_INTERVAL_MSERROR_DESCRIPTION_MAPERROR_FACTORYFID_WAIT_TIME_MSFIRST_CONTENTFUL_PAINT_COUNTER_NAMEFIRST_INPUT_DELAY_COUNTER_NAMEFIRST_PAINT_COUNTER_NAMEFIS_AUTH_PREFIXINITIAL_SEND_TIME_DELAY_MSMAX_ATTRIBUTE_NAME_LENGTHMAX_ATTRIBUTE_VALUE_LENGTHMAX_METRIC_NAME_LENGTHOOB_TRACE_PAGE_LOAD_PREFIXREMOTE_CONFIG_SDK_VERSIONRESERVED_ATTRIBUTE_PREFIXESRESERVED_AUTO_PREFIXSDK_VERSIONSERVICESERVICE_NAMETRACE_MEASURE_PREFIXTRACE_START_MARK_PREFIXTRACE_STOP_MARK_PREFIXVisibilityStateapiInstanceconsoleLoggerfactoryiidinitializationPromiseinitializationStatusisTransportSetuploggernameoobMetricsqueueremainingTriessettingsServiceInstanceversionwindowInstance? External Dependencies
Module Base (0c607c9) Head (5c8621f) Diff @firebase/logger? LogLevelLogger? @firebase/util? ErrorFactoryisIndexedDBAvailablevalidateIndexedDBOpenable? @firebase/app-exp? _getProvider_registerComponentregisterVersion? @firebase/component? Component? -
registerPerformanceSize
Type Base (0c607c9) Head (5c8621f) Diff size ? 16.7 kB ? (?) size_with_ext_deps ? 21.7 kB ? (?) Dependencies
Type Base (0c607c9) Head (5c8621f) Diff functions ? Click to show 49 deps
addToQueuechangeInitializationStatusconfigValidconvertMetricValueToIntegercreateNetworkRequestEntrycreateUserTimingTracedispatchQueueEventsgetApiKeygetAppIdgetApplicationInfogetAuthTokenPromisegetConfiggetDocumentReadyCompletegetEffectiveConnectionTypegetIidgetIidPromisegetInitializationPromisegetProjectIdgetRemoteConfiggetServiceWorkerStatusgetStoredConfiggetVisibilityStateinitializePerfisPerfInitializedisValidCustomAttributeNameisValidCustomAttributeValueisValidMetricNamelogNetworkRequestlogTracemergeStringspostToFlEndpointprocessConfigprocessQueueregisterPerformancesendEventsToFlsendLogsendTraceLogserializeNetworkRequestserializeTraceserializersetupApisetupNetworkRequestssetupOobResourcessetupOobTracessetupTransportServicesetupUserTimingTracesshouldLogAfterSamplingstoreConfigtransportHandler? classes ? ApiPerformanceControllerSettingsServiceTrace? variables ? Click to show 45 deps
ATTRIBUTE_FORMAT_REGEXCONFIG_EXPIRY_LOCAL_STORAGE_KEYCONFIG_LOCAL_STORAGE_KEYCOULD_NOT_GET_CONFIG_MSGDEFAULT_CONFIGSDEFAULT_ENTRY_NAMEDEFAULT_REMAINING_TRIESDEFAULT_SEND_INTERVAL_MSERROR_DESCRIPTION_MAPERROR_FACTORYFID_WAIT_TIME_MSFIRST_CONTENTFUL_PAINT_COUNTER_NAMEFIRST_INPUT_DELAY_COUNTER_NAMEFIRST_PAINT_COUNTER_NAMEFIS_AUTH_PREFIXINITIAL_SEND_TIME_DELAY_MSMAX_ATTRIBUTE_NAME_LENGTHMAX_ATTRIBUTE_VALUE_LENGTHMAX_METRIC_NAME_LENGTHOOB_TRACE_PAGE_LOAD_PREFIXREMOTE_CONFIG_SDK_VERSIONRESERVED_ATTRIBUTE_PREFIXESRESERVED_AUTO_PREFIXSDK_VERSIONSERVICESERVICE_NAMETRACE_MEASURE_PREFIXTRACE_START_MARK_PREFIXTRACE_STOP_MARK_PREFIXVisibilityStateapiInstanceconsoleLoggerfactoryiidinitializationPromiseinitializationStatusisTransportSetuploggernameoobMetricsqueueremainingTriessettingsServiceInstanceversionwindowInstance? External Dependencies
Module Base (0c607c9) Head (5c8621f) Diff @firebase/logger? LogLevelLogger? @firebase/util? ErrorFactoryisIndexedDBAvailablevalidateIndexedDBOpenable? @firebase/app-exp? _registerComponentregisterVersion? @firebase/component? Component? -
traceSize
Type Base (0c607c9) Head (5c8621f) Diff size ? 16.7 kB ? (?) size_with_ext_deps ? 21.7 kB ? (?) Dependencies
Type Base (0c607c9) Head (5c8621f) Diff functions ? Click to show 50 deps
addToQueuechangeInitializationStatusconfigValidconvertMetricValueToIntegercreateNetworkRequestEntrycreateUserTimingTracedispatchQueueEventsgetApiKeygetAppIdgetApplicationInfogetAuthTokenPromisegetConfiggetDocumentReadyCompletegetEffectiveConnectionTypegetIidgetIidPromisegetInitializationPromisegetProjectIdgetRemoteConfiggetServiceWorkerStatusgetStoredConfiggetVisibilityStateinitializePerfisPerfInitializedisValidCustomAttributeNameisValidCustomAttributeValueisValidMetricNamelogNetworkRequestlogTracemergeStringspostToFlEndpointprocessConfigprocessQueueregisterPerformancesendEventsToFlsendLogsendTraceLogserializeNetworkRequestserializeTraceserializersetupApisetupNetworkRequestssetupOobResourcessetupOobTracessetupTransportServicesetupUserTimingTracesshouldLogAfterSamplingstoreConfigtracetransportHandler? classes ? ApiPerformanceControllerSettingsServiceTrace? variables ? Click to show 45 deps
ATTRIBUTE_FORMAT_REGEXCONFIG_EXPIRY_LOCAL_STORAGE_KEYCONFIG_LOCAL_STORAGE_KEYCOULD_NOT_GET_CONFIG_MSGDEFAULT_CONFIGSDEFAULT_ENTRY_NAMEDEFAULT_REMAINING_TRIESDEFAULT_SEND_INTERVAL_MSERROR_DESCRIPTION_MAPERROR_FACTORYFID_WAIT_TIME_MSFIRST_CONTENTFUL_PAINT_COUNTER_NAMEFIRST_INPUT_DELAY_COUNTER_NAMEFIRST_PAINT_COUNTER_NAMEFIS_AUTH_PREFIXINITIAL_SEND_TIME_DELAY_MSMAX_ATTRIBUTE_NAME_LENGTHMAX_ATTRIBUTE_VALUE_LENGTHMAX_METRIC_NAME_LENGTHOOB_TRACE_PAGE_LOAD_PREFIXREMOTE_CONFIG_SDK_VERSIONRESERVED_ATTRIBUTE_PREFIXESRESERVED_AUTO_PREFIXSDK_VERSIONSERVICESERVICE_NAMETRACE_MEASURE_PREFIXTRACE_START_MARK_PREFIXTRACE_STOP_MARK_PREFIXVisibilityStateapiInstanceconsoleLoggerfactoryiidinitializationPromiseinitializationStatusisTransportSetuploggernameoobMetricsqueueremainingTriessettingsServiceInstanceversionwindowInstance? External Dependencies
Module Base (0c607c9) Head (5c8621f) Diff @firebase/logger? LogLevelLogger? @firebase/util? ErrorFactoryisIndexedDBAvailablevalidateIndexedDBOpenable? @firebase/app-exp? _registerComponentregisterVersion? @firebase/component? Component?
Test Logs
- Head (
5c8621ff): https://github.com/firebase/firebase-js-sdk/actions/runs/272944098
|
Split the checks into 2, moved the sync check into factory and the indexedDB check into initializeIds(). |
This was referenced Sep 29, 2020
Closed
Feiyang1
approved these changes
Sep 30, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn instead of throw if analytics detects an environment mismatch (no cookies, no indexedDB, etc.) These should not disrupt the user experience and should fail silently.
In the case of sync checks, it simply returns an empty analytics instance, so that calls to
analytics().logEvent(), etc. do not error but are a no-op.In the case of the async indexedDB.open() check, since it can't complete before the factory initialization finishes, it will cause the initialization promise referenced by
initializationPromisesMap[appId]to throw, and all the code that depends on these promises (the public analytics methods like logEvent, etc., plus the all-apps checks inside gtagOnEvent/gtagOnConfig) will catch the error, log a warning, and skip calling gtag.Question: Is
warnstill too noisy? Is info better?Fixes #3573