Control the maximum amount of events in single logRequest to be 1000 in Performance Monitoring #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2b979e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check
|
Binary Size ReportAffected SDKs
Test Logs
|
Size Analysis ReportAffected Products
|
| Type | Base (9634efd) | Head (a25778f) | Diff |
|---|---|---|---|
| size | 17.3 kB | 17.3 kB | +15 B (+0.1%) |
| size_with_ext_deps | 34.2 kB | 34.3 kB | +15 B (+0.0%) |
Dependencies
| Type | Base (9634efd) | Head (a25778f) | Diff |
|---|---|---|---|
| variables | Click to show 45 depsATTRIBUTE_FORMAT_REGEXCONFIG_EXPIRY_LOCAL_STORAGE_KEYCONFIG_LOCAL_STORAGE_KEYCOULD_NOT_GET_CONFIG_MSGDEFAULT_CONFIGSDEFAULT_ENTRY_NAMEDEFAULT_REMAINING_TRIESDEFAULT_SEND_INTERVAL_MSERROR_DESCRIPTION_MAPERROR_FACTORYFID_WAIT_TIME_MSFIRST_CONTENTFUL_PAINT_COUNTER_NAMEFIRST_INPUT_DELAY_COUNTER_NAMEFIRST_PAINT_COUNTER_NAMEFIS_AUTH_PREFIXINITIAL_SEND_TIME_DELAY_MSMAX_ATTRIBUTE_NAME_LENGTHMAX_ATTRIBUTE_VALUE_LENGTHMAX_METRIC_NAME_LENGTHOOB_TRACE_PAGE_LOAD_PREFIXREMOTE_CONFIG_SDK_VERSIONRESERVED_ATTRIBUTE_PREFIXESRESERVED_AUTO_PREFIXSDK_VERSIONSERVICESERVICE_NAMETRACE_MEASURE_PREFIXTRACE_START_MARK_PREFIXTRACE_STOP_MARK_PREFIXVisibilityStateapiInstanceconsoleLoggerfactoryiidinitializationPromiseinitializationStatusisTransportSetuploggernameoobMetricsqueueremainingTriessettingsServiceInstanceversionwindowInstance |
Click to show 46 depsATTRIBUTE_FORMAT_REGEXCONFIG_EXPIRY_LOCAL_STORAGE_KEYCONFIG_LOCAL_STORAGE_KEYCOULD_NOT_GET_CONFIG_MSGDEFAULT_CONFIGSDEFAULT_ENTRY_NAMEDEFAULT_REMAINING_TRIESDEFAULT_SEND_INTERVAL_MSERROR_DESCRIPTION_MAPERROR_FACTORYFID_WAIT_TIME_MSFIRST_CONTENTFUL_PAINT_COUNTER_NAMEFIRST_INPUT_DELAY_COUNTER_NAMEFIRST_PAINT_COUNTER_NAMEFIS_AUTH_PREFIXINITIAL_SEND_TIME_DELAY_MSMAX_ATTRIBUTE_NAME_LENGTHMAX_ATTRIBUTE_VALUE_LENGTHMAX_EVENT_COUNT_PER_REQUESTMAX_METRIC_NAME_LENGTHOOB_TRACE_PAGE_LOAD_PREFIXREMOTE_CONFIG_SDK_VERSIONRESERVED_ATTRIBUTE_PREFIXESRESERVED_AUTO_PREFIXSDK_VERSIONSERVICESERVICE_NAMETRACE_MEASURE_PREFIXTRACE_START_MARK_PREFIXTRACE_STOP_MARK_PREFIXVisibilityStateapiInstanceconsoleLoggerfactoryiidinitializationPromiseinitializationStatusisTransportSetuploggernameoobMetricsqueueremainingTriessettingsServiceInstanceversionwindowInstance |
+ MAX_EVENT_COUNT_PER_REQUEST |
trace
Size
| Type | Base (9634efd) | Head (a25778f) | Diff |
|---|---|---|---|
| size | 17.2 kB | 17.2 kB | +15 B (+0.1%) |
| size_with_ext_deps | 34.2 kB | 34.2 kB | +15 B (+0.0%) |
Dependencies
| Type | Base (9634efd) | Head (a25778f) | Diff |
|---|---|---|---|
| variables | Click to show 45 depsATTRIBUTE_FORMAT_REGEXCONFIG_EXPIRY_LOCAL_STORAGE_KEYCONFIG_LOCAL_STORAGE_KEYCOULD_NOT_GET_CONFIG_MSGDEFAULT_CONFIGSDEFAULT_ENTRY_NAMEDEFAULT_REMAINING_TRIESDEFAULT_SEND_INTERVAL_MSERROR_DESCRIPTION_MAPERROR_FACTORYFID_WAIT_TIME_MSFIRST_CONTENTFUL_PAINT_COUNTER_NAMEFIRST_INPUT_DELAY_COUNTER_NAMEFIRST_PAINT_COUNTER_NAMEFIS_AUTH_PREFIXINITIAL_SEND_TIME_DELAY_MSMAX_ATTRIBUTE_NAME_LENGTHMAX_ATTRIBUTE_VALUE_LENGTHMAX_METRIC_NAME_LENGTHOOB_TRACE_PAGE_LOAD_PREFIXREMOTE_CONFIG_SDK_VERSIONRESERVED_ATTRIBUTE_PREFIXESRESERVED_AUTO_PREFIXSDK_VERSIONSERVICESERVICE_NAMETRACE_MEASURE_PREFIXTRACE_START_MARK_PREFIXTRACE_STOP_MARK_PREFIXVisibilityStateapiInstanceconsoleLoggerfactoryiidinitializationPromiseinitializationStatusisTransportSetuploggernameoobMetricsqueueremainingTriessettingsServiceInstanceversionwindowInstance |
Click to show 46 depsATTRIBUTE_FORMAT_REGEXCONFIG_EXPIRY_LOCAL_STORAGE_KEYCONFIG_LOCAL_STORAGE_KEYCOULD_NOT_GET_CONFIG_MSGDEFAULT_CONFIGSDEFAULT_ENTRY_NAMEDEFAULT_REMAINING_TRIESDEFAULT_SEND_INTERVAL_MSERROR_DESCRIPTION_MAPERROR_FACTORYFID_WAIT_TIME_MSFIRST_CONTENTFUL_PAINT_COUNTER_NAMEFIRST_INPUT_DELAY_COUNTER_NAMEFIRST_PAINT_COUNTER_NAMEFIS_AUTH_PREFIXINITIAL_SEND_TIME_DELAY_MSMAX_ATTRIBUTE_NAME_LENGTHMAX_ATTRIBUTE_VALUE_LENGTHMAX_EVENT_COUNT_PER_REQUESTMAX_METRIC_NAME_LENGTHOOB_TRACE_PAGE_LOAD_PREFIXREMOTE_CONFIG_SDK_VERSIONRESERVED_ATTRIBUTE_PREFIXESRESERVED_AUTO_PREFIXSDK_VERSIONSERVICESERVICE_NAMETRACE_MEASURE_PREFIXTRACE_START_MARK_PREFIXTRACE_STOP_MARK_PREFIXVisibilityStateapiInstanceconsoleLoggerfactoryiidinitializationPromiseinitializationStatusisTransportSetuploggernameoobMetricsqueueremainingTriessettingsServiceInstanceversionwindowInstance |
+ MAX_EVENT_COUNT_PER_REQUEST |
Test Logs
- Base (
9634efd1): https://github.com/firebase/firebase-js-sdk/actions/runs/406918543 - Head (
a25778f8): https://github.com/firebase/firebase-js-sdk/actions/runs/407140643
jposuna
approved these changes
Oct 14, 2020
alikn
reviewed
Oct 15, 2020
alikn
reviewed
Oct 21, 2020
packages-exp/performance-exp/src/services/transport_service.test.ts
Outdated
Show resolved
Hide resolved
packages-exp/performance-exp/src/services/transport_service.test.ts
Outdated
Show resolved
Hide resolved
packages-exp/performance-exp/src/services/transport_service.test.ts
Outdated
Show resolved
Hide resolved
alikn
force-pushed
the
capPerfLogRequest
branch
from
00c347e
to
2b979e0
Compare
alikn
approved these changes
Dec 8, 2020
hsubox76
approved these changes
Dec 8, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend starts rejecting logRequest with more than 1000 events in batch. In order for client event to be accepted and avoid any unintentional flood, put a cap for each logRequest dispatch to be 1000, extra events will stay in queue until next dispatch.