Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startAfter() and endBefore() to database types #4427

Merged
merged 4 commits into from
Feb 9, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

Add missing public types for startAfter/endBefore.

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2021

🦋 Changeset detected

Latest commit: 318538e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@firebase/database-types Minor
@firebase/database Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 5, 2021

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (e3c55b2) Head (8d6a127) Diff
    browser 276 kB 275 kB -577 B (-0.2%)
    esm2017 243 kB 243 kB -498 B (-0.2%)
    main 279 kB 278 kB -577 B (-0.2%)
    module 276 kB 275 kB -577 B (-0.2%)
  • @firebase/database-exp

    Type Base (e3c55b2) Head (8d6a127) Diff
    browser 277 kB 276 kB -577 B (-0.2%)
    esm2017 241 kB 240 kB -498 B (-0.2%)
    main 279 kB 278 kB -577 B (-0.2%)
    module 277 kB 276 kB -577 B (-0.2%)
  • firebase

    Type Base (e3c55b2) Head (8d6a127) Diff
    firebase-database.js 195 kB 194 kB -618 B (-0.3%)
    firebase.js 856 kB 855 kB -618 B (-0.1%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 5, 2021

Size Analysis Report

Affected Products

  • @firebase/auth-exp

    • ActionCodeURL

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.5 kB
      29.0 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.5 kB
      +469 B (+1.2%)
    • AuthCredential

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.7 kB
      28.2 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.2 kB
      38.7 kB
      +469 B (+1.2%)
    • EmailAuthCredential

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      29.5 kB
      29.9 kB
      +468 B (+1.6%)
      size-with-ext-deps
      40.0 kB
      40.5 kB
      +469 B (+1.2%)
    • EmailAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      30.9 kB
      31.3 kB
      +468 B (+1.5%)
      size-with-ext-deps
      41.4 kB
      41.8 kB
      +469 B (+1.1%)
    • FacebookAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      31.3 kB
      31.8 kB
      +468 B (+1.5%)
      size-with-ext-deps
      41.8 kB
      42.3 kB
      +469 B (+1.1%)
    • GithubAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      31.3 kB
      31.8 kB
      +468 B (+1.5%)
      size-with-ext-deps
      41.8 kB
      42.3 kB
      +469 B (+1.1%)
    • GoogleAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      31.3 kB
      31.8 kB
      +468 B (+1.5%)
      size-with-ext-deps
      41.8 kB
      42.3 kB
      +469 B (+1.1%)
    • OAuthCredential

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      29.5 kB
      30.0 kB
      +468 B (+1.6%)
      size-with-ext-deps
      40.0 kB
      40.5 kB
      +469 B (+1.2%)
    • OAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      30.7 kB
      31.2 kB
      +468 B (+1.5%)
      size-with-ext-deps
      41.2 kB
      41.7 kB
      +469 B (+1.1%)
    • PhoneAuthCredential

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      29.5 kB
      30.0 kB
      +468 B (+1.6%)
      size-with-ext-deps
      40.0 kB
      40.5 kB
      +469 B (+1.2%)
    • PhoneAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      31.1 kB
      31.6 kB
      +468 B (+1.5%)
      size-with-ext-deps
      41.7 kB
      42.1 kB
      +469 B (+1.1%)
    • PhoneMultiFactorGenerator

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.4 kB
      28.9 kB
      +468 B (+1.6%)
      size-with-ext-deps
      38.9 kB
      39.4 kB
      +469 B (+1.2%)
    • RecaptchaVerifier

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      33.7 kB
      34.2 kB
      +468 B (+1.4%)
      size-with-ext-deps
      44.3 kB
      44.7 kB
      +469 B (+1.1%)
    • TwitterAuthProvider

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      31.3 kB
      31.8 kB
      +468 B (+1.5%)
      size-with-ext-deps
      41.8 kB
      42.3 kB
      +469 B (+1.1%)
    • applyActionCode

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.6 kB
      28.1 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.1 kB
      38.6 kB
      +469 B (+1.2%)
    • checkActionCode

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.5 kB
      29.0 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.5 kB
      +469 B (+1.2%)
    • confirmPasswordReset

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.6 kB
      28.1 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.1 kB
      38.6 kB
      +469 B (+1.2%)
    • createUserWithEmailAndPassword

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.5 kB
      29.0 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.5 kB
      +469 B (+1.2%)
    • deleteUser

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      28.0 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +469 B (+1.2%)
    • fetchSignInMethodsForEmail

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.8 kB
      28.3 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.3 kB
      38.8 kB
      +469 B (+1.2%)
    • getAdditionalUserInfo

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.8 kB
      29.3 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.3 kB
      39.8 kB
      +469 B (+1.2%)
    • getAuth

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      55.0 kB
      55.5 kB
      +533 B (+1.0%)
      size-with-ext-deps
      65.7 kB
      66.2 kB
      +535 B (+0.8%)

      Dependency Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      functions

      <full-list-too-large-to-display>
      <see-test-logs-below-for-details>
      

      <full-list-too-large-to-display>
      <see-test-logs-below-for-details>
      

      + _getRedirectUrl
      - getRedirectUrl

    • getIdToken

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      28.0 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +469 B (+1.2%)
    • getIdTokenResult

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      27.9 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.4 kB
      +469 B (+1.2%)
    • getMultiFactorResolver

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      30.2 kB
      30.7 kB
      +468 B (+1.5%)
      size-with-ext-deps
      40.7 kB
      41.2 kB
      +469 B (+1.2%)
    • getRedirectResult

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      33.1 kB
      33.6 kB
      +468 B (+1.4%)
      size-with-ext-deps
      43.6 kB
      44.1 kB
      +469 B (+1.1%)
    • initializeAuth

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.8 kB
      28.3 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.4 kB
      38.8 kB
      +469 B (+1.2%)
    • isSignInWithEmailLink

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.6 kB
      29.1 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.1 kB
      39.6 kB
      +469 B (+1.2%)
    • linkWithCredential

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.5 kB
      29.0 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.5 kB
      +469 B (+1.2%)
    • linkWithPhoneNumber

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      32.0 kB
      32.5 kB
      +468 B (+1.5%)
      size-with-ext-deps
      42.5 kB
      43.0 kB
      +469 B (+1.1%)
    • linkWithPopup

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      36.4 kB
      36.9 kB
      +468 B (+1.3%)
      size-with-ext-deps
      47.0 kB
      47.4 kB
      +469 B (+1.0%)
    • linkWithRedirect

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      31.5 kB
      31.9 kB
      +468 B (+1.5%)
      size-with-ext-deps
      42.0 kB
      42.4 kB
      +469 B (+1.1%)
    • multiFactor

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      29.6 kB
      30.0 kB
      +468 B (+1.6%)
      size-with-ext-deps
      40.1 kB
      40.5 kB
      +469 B (+1.2%)
    • onAuthStateChanged

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      28.0 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +469 B (+1.2%)
    • onIdTokenChanged

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      28.0 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +469 B (+1.2%)
    • parseActionCodeURL

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.5 kB
      29.0 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.5 kB
      +469 B (+1.2%)
    • reauthenticateWithCredential

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      29.1 kB
      29.6 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.6 kB
      40.1 kB
      +469 B (+1.2%)
    • reauthenticateWithPhoneNumber

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      32.6 kB
      33.0 kB
      +468 B (+1.4%)
      size-with-ext-deps
      43.1 kB
      43.6 kB
      +469 B (+1.1%)
    • reauthenticateWithPopup

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      36.4 kB
      36.9 kB
      +468 B (+1.3%)
      size-with-ext-deps
      47.0 kB
      47.4 kB
      +469 B (+1.0%)
    • reauthenticateWithRedirect

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      31.2 kB
      31.7 kB
      +468 B (+1.5%)
      size-with-ext-deps
      41.7 kB
      42.2 kB
      +469 B (+1.1%)
    • reload

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      27.9 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.4 kB
      +469 B (+1.2%)
    • sendEmailVerification

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.4 kB
      28.9 kB
      +468 B (+1.6%)
      size-with-ext-deps
      38.9 kB
      39.4 kB
      +469 B (+1.2%)
    • sendPasswordResetEmail

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.3 kB
      28.8 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.8 kB
      39.3 kB
      +469 B (+1.2%)
    • sendSignInLinkToEmail

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.4 kB
      28.8 kB
      +468 B (+1.6%)
      size-with-ext-deps
      38.9 kB
      39.3 kB
      +469 B (+1.2%)
    • setPersistence

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      28.0 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +469 B (+1.2%)
    • signInAnonymously

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.6 kB
      29.1 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.1 kB
      39.6 kB
      +469 B (+1.2%)
    • signInWithCredential

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.9 kB
      29.4 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.4 kB
      39.9 kB
      +469 B (+1.2%)
    • signInWithCustomToken

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.5 kB
      29.0 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.5 kB
      +469 B (+1.2%)
    • signInWithEmailAndPassword

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      32.3 kB
      32.8 kB
      +468 B (+1.4%)
      size-with-ext-deps
      42.8 kB
      43.3 kB
      +469 B (+1.1%)
    • signInWithEmailLink

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      32.5 kB
      33.0 kB
      +468 B (+1.4%)
      size-with-ext-deps
      43.0 kB
      43.5 kB
      +469 B (+1.1%)
    • signInWithPhoneNumber

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      32.4 kB
      32.8 kB
      +468 B (+1.4%)
      size-with-ext-deps
      42.9 kB
      43.3 kB
      +469 B (+1.1%)
    • signInWithPopup

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      36.4 kB
      36.9 kB
      +468 B (+1.3%)
      size-with-ext-deps
      46.9 kB
      47.4 kB
      +469 B (+1.0%)
    • signInWithRedirect

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      30.9 kB
      31.4 kB
      +468 B (+1.5%)
      size-with-ext-deps
      41.4 kB
      41.9 kB
      +469 B (+1.1%)
    • signOut

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      28.0 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +469 B (+1.2%)
    • unlink

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.1 kB
      28.5 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.6 kB
      39.0 kB
      +469 B (+1.2%)
    • updateCurrentUser

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      28.0 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +469 B (+1.2%)
    • updateEmail

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.8 kB
      28.3 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.3 kB
      38.8 kB
      +469 B (+1.2%)
    • updatePassword

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.8 kB
      28.3 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.3 kB
      38.8 kB
      +469 B (+1.2%)
    • updatePhoneNumber

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.2 kB
      28.7 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.7 kB
      39.2 kB
      +469 B (+1.2%)
    • updateProfile

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.0 kB
      28.4 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.5 kB
      38.9 kB
      +469 B (+1.2%)
    • useAuthEmulator

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.5 kB
      29.0 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.0 kB
      39.5 kB
      +469 B (+1.2%)
    • useDeviceLanguage

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      28.0 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.5 kB
      +469 B (+1.2%)
    • verifyBeforeUpdateEmail

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.4 kB
      28.9 kB
      +468 B (+1.6%)
      size-with-ext-deps
      38.9 kB
      39.4 kB
      +469 B (+1.2%)
    • verifyPasswordResetCode

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.6 kB
      29.1 kB
      +468 B (+1.6%)
      size-with-ext-deps
      39.1 kB
      39.6 kB
      +469 B (+1.2%)
    • browserLocalPersistence

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      30.5 kB
      30.9 kB
      +472 B (+1.6%)
      size-with-ext-deps
      41.0 kB
      41.5 kB
      +473 B (+1.2%)
    • browserPopupRedirectResolver

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      44.8 kB
      45.3 kB
      +533 B (+1.2%)
      size-with-ext-deps
      55.4 kB
      55.9 kB
      +535 B (+1.0%)

      Dependency Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      functions

      <full-list-too-large-to-display>
      <see-test-logs-below-for-details>
      

      <full-list-too-large-to-display>
      <see-test-logs-below-for-details>
      

      + _getRedirectUrl
      - getRedirectUrl

    • browserSessionPersistence

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      28.1 kB
      28.6 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.6 kB
      39.1 kB
      +469 B (+1.2%)
    • debugErrorMap

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      38.0 kB
      38.7 kB
      +702 B (+1.8%)
      size-with-ext-deps
      48.5 kB
      49.2 kB
      +703 B (+1.4%)
    • inMemoryPersistence

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      27.9 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.4 kB
      +469 B (+1.2%)
    • indexedDBLocalPersistence

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      34.9 kB
      35.3 kB
      +468 B (+1.3%)
      size-with-ext-deps
      45.3 kB
      45.8 kB
      +469 B (+1.0%)
    • prodErrorMap

      Size Table

      TypeBase (e3c55b2)Head (8d6a127)Diff
      size
      27.5 kB
      27.9 kB
      +468 B (+1.7%)
      size-with-ext-deps
      38.0 kB
      38.4 kB
      +469 B (+1.2%)

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, thanks!

packages/firebase/index.d.ts Show resolved Hide resolved
packages/firebase/index.d.ts Show resolved Hide resolved
* The ending point is exclusive. If only a value is provided, children
* with a value less than the specified value will be included in the query.
* If a key is specified, then children must have a value lesss than or equal
* to the specified value and a a key name less than the specified key.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

packages/firebase/index.d.ts Show resolved Hide resolved
* allows you to choose arbitrary starting and ending points for your queries.
*
* The starting point is exclusive. If only a value is provided, children
* with a value greater than the specified value will be included in the query.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above; "are included"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/firebase/index.d.ts Show resolved Hide resolved
Copy link
Contributor Author

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Feedback addressed.

packages/firebase/index.d.ts Show resolved Hide resolved
* The ending point is exclusive. If only a value is provided, children
* with a value less than the specified value will be included in the query.
* If a key is specified, then children must have a value lesss than or equal
* to the specified value and a a key name less than the specified key.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

packages/firebase/index.d.ts Show resolved Hide resolved
* allows you to choose arbitrary starting and ending points for your queries.
*
* The starting point is exclusive. If only a value is provided, children
* with a value greater than the specified value will be included in the query.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/firebase/index.d.ts Show resolved Hide resolved
packages/firebase/index.d.ts Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

Changeset File Check ⚠️

  • Package @firebase/database-types has a minor bump. Increase the bump for the main "firebase" package to minor.

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@schmidt-sebastian schmidt-sebastian merged commit 05614aa into master Feb 9, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmdit/startaftertypes branch February 9, 2021 21:33
@google-oss-bot google-oss-bot mentioned this pull request Feb 9, 2021
@firebase firebase locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants