Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for a navigator that has a key of serviceWorker but an undefined value #6723

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Account for a navigator that has a key of serviceWorker but an undefined value #6723

merged 1 commit into from
Oct 25, 2022

Conversation

dwyfrequency
Copy link
Contributor

#6657 Cannot read property 'controller' of undefined

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022

🦋 Changeset detected

Latest commit: be4159d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/performance Patch
firebase Patch
@firebase/performance-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dwyfrequency dwyfrequency marked this pull request as ready for review October 24, 2022 22:06
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/performance

    TypeBase (8f031b4)Merge (5bf2176)Diff
    browser29.1 kB29.1 kB+40 B (+0.1%)
    esm530.8 kB30.8 kB+40 B (+0.1%)
    main31.2 kB31.3 kB+40 B (+0.1%)
    module29.1 kB29.1 kB+40 B (+0.1%)

  • bundle

    TypeBase (8f031b4)Merge (5bf2176)Diff
    performance (trace)50.8 kB50.8 kB+24 B (+0.0%)

  • firebase

    TypeBase (8f031b4)Merge (5bf2176)Diff
    firebase-compat.js740 kB740 kB+6 B (+0.0%)
    firebase-performance-compat.js30.7 kB30.7 kB+6 B (+0.0%)
    firebase-performance-standalone-compat.es2017.js90.0 kB90.0 kB+13 B (+0.0%)
    firebase-performance-standalone-compat.js66.5 kB66.5 kB+6 B (+0.0%)
    firebase-performance.js30.7 kB30.7 kB+13 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4kqqXATl8h.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/performance

    • getPerformance

      Size

      TypeBase (8f031b4)Merge (5bf2176)Diff
      size18.0 kB18.0 kB+24 B (+0.1%)
      size-with-ext-deps50.7 kB50.7 kB+24 B (+0.0%)

    • initializePerformance

      Size

      TypeBase (8f031b4)Merge (5bf2176)Diff
      size18.2 kB18.2 kB+24 B (+0.1%)
      size-with-ext-deps44.1 kB44.1 kB+24 B (+0.1%)

    • trace

      Size

      TypeBase (8f031b4)Merge (5bf2176)Diff
      size17.9 kB17.9 kB+24 B (+0.1%)
      size-with-ext-deps43.5 kB43.5 kB+24 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/j5brbEhRvV.html

@dwyfrequency dwyfrequency changed the title Expand check in getServiceWorkerStatus to account for a navigator that has a key of serviceWorker with a falsy value Account for a navigator that has a key of serviceWorker but an undefined value Oct 25, 2022
@dwyfrequency dwyfrequency mentioned this pull request Oct 25, 2022
Closed
egilmorez
egilmorez approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

@dwyfrequency dwyfrequency merged commit 3f1354f into master Oct 25, 2022
@dwyfrequency dwyfrequency deleted the performance-iss-6657 branch October 25, 2022 20:00
@google-oss-bot google-oss-bot mentioned this pull request Nov 8, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@egilmorez egilmorez egilmorez approved these changes

@jposuna jposuna jposuna approved these changes

@lahirumaramba lahirumaramba Awaiting requested review from lahirumaramba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwyfrequency @google-oss-bot @jposuna @egilmorez