Add createTime to Document. #6781

ehsannas · 2022-11-10T23:39:44Z

No description provided.

changeset-bot · 2022-11-10T23:39:46Z

⚠️ No Changeset found

Latest commit: c80911d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2022-11-10T23:42:04Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

google-oss-bot · 2022-11-11T00:03:05Z

Size Report ¹

Affected Products

@firebase/analytics
Type Base (09dfc3a) Merge (0af8d2b) Diff
browser 20.2 kB 20.1 kB -24 B (-0.1%)
esm5 24.7 kB 24.8 kB +89 B (+0.4%)
main 26.0 kB 26.1 kB +89 B (+0.3%)
module 20.2 kB 20.1 kB -24 B (-0.1%)
@firebase/app
Type Base (09dfc3a) Merge (0af8d2b) Diff
browser 14.4 kB 14.3 kB -28 B (-0.2%)
esm5 18.7 kB 18.8 kB +103 B (+0.6%)
main 19.6 kB 19.7 kB +103 B (+0.5%)
module 14.4 kB 14.3 kB -28 B (-0.2%)
@firebase/app-check
Type Base (09dfc3a) Merge (0af8d2b) Diff
browser 25.2 kB 25.2 kB +10 B (+0.0%)
esm5 30.0 kB 30.3 kB +230 B (+0.8%)
main 31.1 kB 31.3 kB +230 B (+0.7%)
module 25.2 kB 25.2 kB +10 B (+0.0%)

`@firebase/auth`

Type	Base (`09dfc3a`)	Merge (`0af8d2b`)	Diff
browser	156 kB	156 kB	-92 B (-0.1%)
cordova	183 kB	184 kB	+330 B (+0.2%)
esm5	204 kB	205 kB	+441 B (+0.2%)
main	148 kB	149 kB	+266 B (+0.2%)
module	156 kB	156 kB	-92 B (-0.1%)
react-native	168 kB	168 kB	+301 B (+0.2%)

@firebase/auth-compat
Type Base (09dfc3a) Merge (0af8d2b) Diff
browser 20.2 kB 20.2 kB -10 B (-0.0%)
esm5 27.1 kB 27.1 kB -10 B (-0.0%)
main 29.6 kB 29.6 kB -10 B (-0.0%)
module 20.2 kB 20.2 kB -10 B (-0.0%)
@firebase/auth/cordova
Type Base (09dfc3a) Merge (0af8d2b) Diff
browser 183 kB 184 kB +330 B (+0.2%)
module 183 kB 184 kB +330 B (+0.2%)
@firebase/auth/internal
Type Base (09dfc3a) Merge (0af8d2b) Diff
browser 167 kB 167 kB -92 B (-0.1%)
esm5 218 kB 218 kB +452 B (+0.2%)
main 184 kB 184 kB +319 B (+0.2%)
module 167 kB 167 kB -92 B (-0.1%)
@firebase/auth/react-native
Type Base (09dfc3a) Merge (0af8d2b) Diff
browser 168 kB 168 kB +301 B (+0.2%)
module 168 kB 168 kB +301 B (+0.2%)
@firebase/component
Type Base (09dfc3a) Merge (0af8d2b) Diff
esm5 8.61 kB 8.70 kB +87 B (+1.0%)
main 8.99 kB 9.08 kB +87 B (+1.0%)
@firebase/database
Type Base (09dfc3a) Merge (0af8d2b) Diff
esm5 275 kB 276 kB +223 B (+0.1%)
main 281 kB 281 kB +223 B (+0.1%)
@firebase/database-compat/standalone
Type Base (09dfc3a) Merge (0af8d2b) Diff
main 369 kB 370 kB +217 B (+0.1%)
@firebase/firestore
Type Base (09dfc3a) Merge (0af8d2b) Diff
browser 272 kB 272 kB +292 B (+0.1%)
esm5 339 kB 339 kB +279 B (+0.1%)
main 545 kB 545 kB +510 B (+0.1%)
module 272 kB 272 kB +292 B (+0.1%)
react-native 272 kB 273 kB +292 B (+0.1%)

`@firebase/firestore-lite`

Type	Base (`09dfc3a`)	Merge (`0af8d2b`)	Diff
browser	85.9 kB	86.2 kB	+301 B (+0.4%)
esm5	104 kB	104 kB	+310 B (+0.3%)
main	146 kB	147 kB	+511 B (+0.3%)
module	85.9 kB	86.2 kB	+301 B (+0.4%)
react-native	86.1 kB	86.4 kB	+301 B (+0.3%)

@firebase/functions
Type Base (09dfc3a) Merge (0af8d2b) Diff
esm5 11.7 kB 11.8 kB +117 B (+1.0%)
main 12.5 kB 12.6 kB +117 B (+0.9%)
@firebase/installations
Type Base (09dfc3a) Merge (0af8d2b) Diff
esm5 22.9 kB 23.1 kB +104 B (+0.5%)
main 23.8 kB 23.9 kB +104 B (+0.4%)
@firebase/logger
Type Base (09dfc3a) Merge (0af8d2b) Diff
esm5 4.65 kB 4.75 kB +98 B (+2.1%)
main 5.32 kB 5.41 kB +98 B (+1.8%)
@firebase/messaging
Type Base (09dfc3a) Merge (0af8d2b) Diff
browser 21.4 kB 21.4 kB -44 B (-0.2%)
esm5 26.8 kB 26.8 kB +42 B (+0.2%)
main 27.5 kB 27.5 kB +42 B (+0.2%)
module 21.4 kB 21.4 kB -44 B (-0.2%)
@firebase/messaging-sw
Type Base (09dfc3a) Merge (0af8d2b) Diff
main 30.2 kB 30.2 kB +60 B (+0.2%)
module 23.4 kB 23.4 kB -30 B (-0.1%)
@firebase/performance
Type Base (09dfc3a) Merge (0af8d2b) Diff
esm5 30.8 kB 31.0 kB +171 B (+0.6%)
main 31.3 kB 31.5 kB +171 B (+0.5%)
@firebase/remote-config
Type Base (09dfc3a) Merge (0af8d2b) Diff
esm5 24.0 kB 24.1 kB +81 B (+0.3%)
main 25.2 kB 25.3 kB +81 B (+0.3%)
@firebase/storage
Type Base (09dfc3a) Merge (0af8d2b) Diff
esm5 62.3 kB 62.5 kB +229 B (+0.4%)
main 58.5 kB 58.5 kB -28 B (-0.0%)
@firebase/util
Type Base (09dfc3a) Merge (0af8d2b) Diff
esm5 24.1 kB 24.2 kB +112 B (+0.5%)
main 29.6 kB 29.7 kB +112 B (+0.4%)

`bundle`

43 size changes

Type	Base (`09dfc3a`)	Merge (`0af8d2b`)	Diff
analytics (logEvent)	43.0 kB	43.0 kB	-36 B (-0.1%)
app-check (CustomProvider)	36.2 kB	36.1 kB	-46 B (-0.1%)
app-check (ReCaptchaEnterpriseProvider)	38.5 kB	38.4 kB	-46 B (-0.1%)
app-check (ReCaptchaV3Provider)	38.4 kB	38.4 kB	-46 B (-0.1%)
auth (Anonymous)	67.5 kB	67.4 kB	-70 B (-0.1%)
auth (EmailAndPassword)	71.6 kB	71.5 kB	-70 B (-0.1%)
auth (GoogleFBTwitterGitHubPopup)	93.9 kB	93.8 kB	-80 B (-0.1%)
auth (GooglePopup)	91.2 kB	91.1 kB	-80 B (-0.1%)
auth (GoogleRedirect)	91.4 kB	91.3 kB	-80 B (-0.1%)
auth (Phone)	77.6 kB	77.6 kB	-70 B (-0.1%)
database (Append to a list of data)	148 kB	148 kB	-20 B (-0.0%)
database (Filtering data)	147 kB	147 kB	-20 B (-0.0%)
database (Listen for child events)	163 kB	163 kB	-20 B (-0.0%)
database (Listen for value events + Detach listeners)	163 kB	163 kB	-20 B (-0.0%)
database (Listen for value events)	163 kB	163 kB	-20 B (-0.0%)
database (Read data once)	163 kB	163 kB	-20 B (-0.0%)
database (Save data as transactions)	165 kB	165 kB	-20 B (-0.0%)
database (Sort data)	148 kB	148 kB	-20 B (-0.0%)
database (Write data)	147 kB	147 kB	-20 B (-0.0%)
firestore (Persistence)	281 kB	281 kB	+217 B (+0.1%)
firestore (Query Cursors)	220 kB	220 kB	+130 B (+0.1%)
firestore (Query)	217 kB	217 kB	+130 B (+0.1%)
firestore (Read data once)	204 kB	204 kB	+130 B (+0.1%)
firestore (Realtime updates)	207 kB	207 kB	+130 B (+0.1%)
firestore (Transaction)	188 kB	188 kB	+124 B (+0.1%)
firestore (Write data)	188 kB	188 kB	+69 B (+0.0%)
firestore-lite (Query Cursors)	81.0 kB	81.2 kB	+226 B (+0.3%)
firestore-lite (Query)	77.2 kB	77.4 kB	+226 B (+0.3%)
firestore-lite (Read data once)	59.1 kB	59.3 kB	+238 B (+0.4%)
firestore-lite (Transaction)	83.7 kB	84.0 kB	+238 B (+0.3%)
firestore-lite (Write data)	68.9 kB	68.9 kB	-20 B (-0.0%)
functions (call)	30.9 kB	30.9 kB	-20 B (-0.1%)
messaging (send + receive)	46.4 kB	46.3 kB	-60 B (-0.1%)
performance (trace)	50.8 kB	50.8 kB	-20 B (-0.0%)
remote-config (getAndFetch)	45.4 kB	45.3 kB	-92 B (-0.2%)
storage (getBytes)	40.1 kB	40.0 kB	-20 B (-0.0%)
storage (getDownloadURL)	42.1 kB	42.1 kB	-20 B (-0.0%)
storage (getMetadata)	41.6 kB	41.6 kB	-20 B (-0.0%)
storage (list + listAll)	41.0 kB	41.0 kB	-20 B (-0.0%)
storage (updateMetadata)	41.8 kB	41.8 kB	-20 B (-0.0%)
storage (uploadBytes)	46.8 kB	46.8 kB	-20 B (-0.0%)
storage (uploadBytesResumable)	56.8 kB	56.7 kB	-20 B (-0.0%)
storage (uploadString)	47.0 kB	47.0 kB	-20 B (-0.0%)

`firebase`

21 size changes

Type	Base (`09dfc3a`)	Merge (`0af8d2b`)	Diff
firebase-analytics-compat.js	25.8 kB	25.8 kB	-30 B (-0.1%)
firebase-analytics.js	24.9 kB	24.9 kB	-42 B (-0.2%)
firebase-app-check-compat.js	22.7 kB	22.6 kB	-39 B (-0.2%)
firebase-app-check.js	21.4 kB	21.3 kB	-65 B (-0.3%)
firebase-app-compat.js	28.8 kB	28.7 kB	-26 B (-0.1%)
firebase-app.js	91.7 kB	91.9 kB	+260 B (+0.3%)
firebase-auth-compat.js	126 kB	126 kB	-104 B (-0.1%)
firebase-auth-cordova.js	137 kB	138 kB	+277 B (+0.2%)
firebase-auth-react-native.js	149 kB	150 kB	+391 B (+0.3%)
firebase-auth.js	117 kB	117 kB	-161 B (-0.1%)
firebase-compat.js	746 kB	745 kB	-102 B (-0.0%)
firebase-firestore-compat.js	319 kB	320 kB	+292 B (+0.1%)
firebase-firestore-lite.js	92.6 kB	92.9 kB	+301 B (+0.3%)
firebase-firestore.js	321 kB	321 kB	+292 B (+0.1%)
firebase-messaging-compat.js	38.3 kB	38.2 kB	-91 B (-0.2%)
firebase-messaging-sw.js	26.0 kB	26.0 kB	-69 B (-0.3%)
firebase-messaging.js	24.9 kB	24.8 kB	-92 B (-0.4%)
firebase-performance-standalone-compat.es2017.js	90.0 kB	89.9 kB	-46 B (-0.1%)
firebase-performance-standalone-compat.js	66.5 kB	67.0 kB	+538 B (+0.8%)
firebase-remote-config-compat.js	27.3 kB	27.2 kB	-104 B (-0.4%)
firebase-remote-config.js	26.4 kB	26.3 kB	-176 B (-0.7%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/VrPlhauezw.html

google-oss-bot · 2022-11-11T01:05:45Z

Size Analysis Report ¹

This report is too large (147,575 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/iUNr4jI2du.html

packages/firestore/src/model/document.ts

packages/firestore/test/unit/local/local_store.test.ts

wu-hui

Two more tests requested, but LGTM so you can merge after adding them.

packages/firestore/test/unit/local/local_store.test.ts

* Add createTime to Document. * More createTime tests * All tests pass except for Bundles tests. * Don't use createTime in isEqual. * getBaseDocument should always get results from remoteDocumentCache. * Bring back tests. * Add test that checks createTime gets updated after remote event. * Add test for Set->RemoteEvent->Ack. * try higher timeout. Co-authored-by: Wu-Hui <wu.hui.github@gmail.com>

Add createTime to Document.

7080047

ehsannas self-assigned this Nov 10, 2022

ehsannas assigned wu-hui and unassigned ehsannas Nov 11, 2022

ehsannas requested a review from wu-hui November 11, 2022 00:50

wu-hui reviewed Nov 11, 2022

View reviewed changes

packages/firestore/src/model/document.ts Show resolved Hide resolved

packages/firestore/test/unit/local/local_store.test.ts Show resolved Hide resolved

More createTime tests

97b2957

ehsannas assigned ehsannas and unassigned wu-hui Nov 11, 2022

ehsannas added 4 commits November 21, 2022 15:53

All tests pass except for Bundles tests.

467ed0e

Don't use createTime in isEqual.

fcac75d

getBaseDocument should always get results from remoteDocumentCache.

a5b06da

Bring back tests.

cd61c7d

ehsannas assigned wu-hui and unassigned ehsannas Nov 24, 2022

wu-hui approved these changes Nov 29, 2022

View reviewed changes

packages/firestore/test/unit/local/local_store.test.ts Show resolved Hide resolved

wu-hui assigned ehsannas and unassigned wu-hui Nov 29, 2022

ehsannas added 4 commits November 29, 2022 15:16

Add test that checks createTime gets updated after remote event.

eea9d45

Merge remote-tracking branch 'origin/master' into store-create-time

a43bbdd

Add test for Set->RemoteEvent->Ack.

a763e61

try higher timeout.

c80911d

ehsannas merged commit 649e7f3 into master Dec 2, 2022

ehsannas deleted the ehsann/store-create-time branch December 2, 2022 20:23

firebase locked and limited conversation to collaborators Jan 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add createTime to Document. #6781

Add createTime to Document. #6781

ehsannas commented Nov 10, 2022

changeset-bot bot commented Nov 10, 2022 •

edited

Loading

github-actions bot commented Nov 10, 2022 •

edited

Loading

google-oss-bot commented Nov 11, 2022 •

edited

Loading

`@firebase/analytics`

`@firebase/app`

`@firebase/app-check`

`@firebase/auth`

`@firebase/auth-compat`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`@firebase/component`

`@firebase/database`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/installations`

`@firebase/logger`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/performance`

`@firebase/remote-config`

`@firebase/storage`

`@firebase/util`

`bundle`

`firebase`

google-oss-bot commented Nov 11, 2022 •

edited

Loading

wu-hui left a comment

Add createTime to Document. #6781

Add createTime to Document. #6781

Conversation

ehsannas commented Nov 10, 2022

changeset-bot bot commented Nov 10, 2022 • edited Loading

⚠️ No Changeset found

github-actions bot commented Nov 10, 2022 • edited Loading

Changeset File Check ✅

google-oss-bot commented Nov 11, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/analytics

@firebase/app

@firebase/app-check

@firebase/auth

@firebase/auth-compat

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

@firebase/component

@firebase/database

@firebase/database-compat/standalone

@firebase/firestore

@firebase/firestore-lite

@firebase/functions

@firebase/installations

@firebase/logger

@firebase/messaging

@firebase/messaging-sw

@firebase/performance

@firebase/remote-config

@firebase/storage

@firebase/util

bundle

firebase

Test Logs

google-oss-bot commented Nov 11, 2022 • edited Loading

Size Analysis Report 1

Test Logs

wu-hui left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Nov 10, 2022 •

edited

Loading

github-actions bot commented Nov 10, 2022 •

edited

Loading

google-oss-bot commented Nov 11, 2022 •

edited

Loading

Size Report ¹

`@firebase/analytics`

`@firebase/app`

`@firebase/app-check`

`@firebase/auth`

`@firebase/auth-compat`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`@firebase/component`

`@firebase/database`

`@firebase/database-compat/standalone`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/installations`

`@firebase/logger`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/performance`

`@firebase/remote-config`

`@firebase/storage`

`@firebase/util`

`bundle`

`firebase`

google-oss-bot commented Nov 11, 2022 •

edited

Loading

Size Analysis Report ¹