Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Began reporting client sdk information #8271

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

maneesht
Copy link
Contributor

No description provided.

@maneesht maneesht requested a review from a team as a code owner May 29, 2024 21:56
Copy link

changeset-bot bot commented May 29, 2024

⚠️ No Changeset found

Latest commit: a73e3aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 29, 2024

Size Report 1

Affected Products

  • @firebase/data-connect

    TypeBase (01ca9df)Merge (a2d24b3)Diff
    browser16.1 kB16.2 kB+110 B (+0.7%)
    esm518.1 kB18.2 kB+110 B (+0.6%)
    main20.1 kB20.2 kB+110 B (+0.5%)
    module16.1 kB16.2 kB+110 B (+0.7%)
  • firebase

    TypeBase (01ca9df)Merge (a2d24b3)Diff
    firebase-data-connect.js14.0 kB14.1 kB+37 B (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/K3c4HvmgWO.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 29, 2024

Size Analysis Report 1

Affected Products

  • @firebase/data-connect

    • DataConnect

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.38 kB9.44 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.4 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      12 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      13 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.41 kB9.47 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.5 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      12 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      13 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • FirebaseAuthProvider

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.39 kB9.45 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.4 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      12 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      13 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • MUTATION_STR

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.40 kB9.46 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.5 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      12 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      13 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • MutationManager

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.39 kB9.45 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.4 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      12 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      13 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • QUERY_STR

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.38 kB9.44 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.4 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      12 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      13 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • SOURCE_CACHE

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.38 kB9.44 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.4 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      12 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      13 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • SOURCE_SERVER

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.38 kB9.44 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.4 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      12 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      13 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • connectDataConnectEmulator

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.47 kB9.53 kB+60 B (+0.6%)
      size-with-ext-deps27.5 kB27.5 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      13 dependencies

      addToken
      compareDates
      connectDataConnectEmulator
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      14 dependencies

      addToken
      compareDates
      connectDataConnectEmulator
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • executeMutation

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.46 kB9.52 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.5 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      13 dependencies

      addToken
      compareDates
      dcFetch
      executeMutation
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      14 dependencies

      addToken
      compareDates
      dcFetch
      executeMutation
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • executeQuery

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.45 kB9.51 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.5 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      13 dependencies

      addToken
      compareDates
      dcFetch
      executeQuery
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      14 dependencies

      addToken
      compareDates
      dcFetch
      executeQuery
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • getDataConnect

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.87 kB9.93 kB+60 B (+0.6%)
      size-with-ext-deps34.9 kB35.0 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      13 dependencies

      addToken
      compareDates
      dcFetch
      getDataConnect
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      14 dependencies

      addToken
      compareDates
      dcFetch
      getDataConnect
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • mutationRef

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.50 kB9.56 kB+60 B (+0.6%)
      size-with-ext-deps27.5 kB27.6 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      13 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      mutationRef
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      14 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      mutationRef
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • parseOptions

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.38 kB9.44 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.4 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      12 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      13 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • queryRef

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.50 kB9.56 kB+60 B (+0.6%)
      size-with-ext-deps27.5 kB27.6 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      13 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      queryRef
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      14 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      queryRef
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • setLogLevel

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.41 kB9.47 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.5 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      13 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setLogLevel
      setSDKVersion
      urlBuilder

      14 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setLogLevel
      setSDKVersion
      urlBuilder

      + getGoogApiClientValue

    • subscribe

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size10.4 kB10.5 kB+60 B (+0.6%)
      size-with-ext-deps35.5 kB35.6 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      16 dependencies

      addToken
      compareDates
      dcFetch
      getDataConnect
      getRefSerializer
      logDebug
      logError
      parseOptions
      queryRef
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      subscribe
      toQueryRef
      urlBuilder

      17 dependencies

      addToken
      compareDates
      dcFetch
      getDataConnect
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      queryRef
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      subscribe
      toQueryRef
      urlBuilder

      + getGoogApiClientValue

    • terminate

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size9.41 kB9.47 kB+60 B (+0.6%)
      size-with-ext-deps27.4 kB27.5 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      13 dependencies

      addToken
      compareDates
      dcFetch
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      terminate
      urlBuilder

      14 dependencies

      addToken
      compareDates
      dcFetch
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      terminate
      urlBuilder

      + getGoogApiClientValue

    • toQueryRef

      Size

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      size10.1 kB10.1 kB+60 B (+0.6%)
      size-with-ext-deps35.1 kB35.2 kB+63 B (+0.2%)

      Dependency

      TypeBase (01ca9df)Merge (a2d24b3)Diff
      functions

      15 dependencies

      addToken
      compareDates
      dcFetch
      getDataConnect
      getRefSerializer
      logDebug
      logError
      parseOptions
      queryRef
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      toQueryRef
      urlBuilder

      16 dependencies

      addToken
      compareDates
      dcFetch
      getDataConnect
      getGoogApiClientValue
      getRefSerializer
      logDebug
      logError
      parseOptions
      queryRef
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      toQueryRef
      urlBuilder

      + getGoogApiClientValue

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/M3AQAI2htf.html

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might want to merge master into the main dataconnect branch? It looks like you merged master into this branch but not the main dataconnect branch so there's a really big diff that includes a lot of unrelated changes?

@maneesht
Copy link
Contributor Author

I think you might want to merge master into the main dataconnect branch? It looks like you merged master into this branch but not the main dataconnect branch so there's a really big diff that includes a lot of unrelated changes?

Ah, good point. Done, thanks

@maneesht maneesht requested a review from a team as a code owner May 31, 2024 17:02
@@ -19,6 +19,7 @@ https://github.com/firebase/firebase-js-sdk
| [@firebase/app](./app.md#app_package) | Firebase App |
| [@firebase/app-check](./app-check.md#app-check_package) | The Firebase App Check Web SDK. |
| [@firebase/auth](./auth.md#auth_package) | Firebase Authentication |
| [@firebase/data-connect](./data-connect.md#data-connect_package) | Firebase Data Connect |
Copy link
Collaborator

@markarndt markarndt May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is docs-devsite/data-connect.md in another branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in this branch I believe

@maneesht maneesht merged commit ceed056 into dataconnect Jun 4, 2024
31 of 39 checks passed
@maneesht maneesht deleted the mtewani/update-client-reporting branch June 4, 2024 19:00
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants