Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not serve emulators unless explicitly requested #1016

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Do not serve emulators unless explicitly requested #1016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/commands/serve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var filterTargets = require("../filterTargets");
var getProjectNumber = require("../getProjectNumber");

var VALID_EMULATORS = ["database", "firestore"];
var VALID_TARGETS = ["functions", "hosting", "database", "firestore"];
var VALID_TARGETS = ["functions", "hosting"];

var filterOnlyEmulators = (only) => {
if (!only) {
Expand All @@ -34,7 +34,9 @@ module.exports = new Command("serve")
.option("-o, --host <host>", "the host on which to listen (default: localhost)", "localhost")
.option(
"--only <targets>",
"only serve specified targets (valid targets are: " + VALID_TARGETS.join(", ") + ")"
"only serve specified targets (valid targets are: " +
_.union(VALID_TARGETS, VALID_EMULATORS).join(", ") +
")"
)
.option(
"--except <targets>",
Expand Down