Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript functionsProxy #1037

Merged
merged 7 commits into from Dec 4, 2018
Merged

Typescript functionsProxy #1037

merged 7 commits into from Dec 4, 2018

Conversation

bkendall
Copy link
Contributor

Description

Rewrite hosting's function proxy in Typescript.

Scenarios Tested

firebase serve a project with a function and curl'd the endpoint to make sure it worked.

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Nov 26, 2018
@coveralls
Copy link

coveralls commented Nov 26, 2018 •
edited

Coverage Status

Coverage increased (+0.9%) to 60.841% when pulling 5730c34 on bk-typescript-functions-proxy into 6322ffb on master.

@bkendall
Copy link
Contributor Author

Coverage increased (+1.0%)

AWWWWWWW YEAAAAHHHHH

mbleigh
mbleigh reviewed Nov 29, 2018
View reviewed changes
package.json Show resolved Hide resolved
mbleigh
mbleigh requested changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@mbleigh mbleigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to add express as a dependency, especially just to get its types.

@mbleigh mbleigh assigned bkendall and unassigned mbleigh Nov 30, 2018
@bkendall bkendall merged commit 40afb70 into master Dec 4, 2018
@bkendall bkendall deleted the bk-typescript-functions-proxy branch December 4, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbleigh mbleigh mbleigh approved these changes

Assignees

@bkendall bkendall

Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkendall @coveralls @mbleigh @googlebot