-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locally serving Hosting proxies Cloud Run rewrites #1187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be fantastic if there was a functional test for this, but I realize that that's more difficult than it may seem. Otherwise, LGTM (assuming things work 🙂)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes way more sense this way. :) Thanks
When running
firebase serve
the local Hosting instance will proxy Cloud Run rewrites configured in thefirebase.json
file to the Cloud Run service that is running in the current project. In the process I refactored out the "proxy" code from locally serving Functions into a shared file.