Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type of findAvailableLogFile #5189

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Conversation

kazuooooo
Copy link
Contributor

Description

Just add return type of bin/firebase.ts findAvailableLogs.
Just it🙏

Scenarios Tested

No need

Sample Commands

No need

@google-cla
Copy link

google-cla bot commented Oct 29, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bkendall
Copy link
Contributor

bkendall commented Dec 5, 2022

Simple enough 😄 Thanks!

@bkendall bkendall enabled auto-merge (squash) December 5, 2022 22:43
@codecov-commenter
Copy link

Codecov Report

Base: 56.29% // Head: 56.29% // No change to project coverage 👍

Coverage data is based on head (45d24ba) compared to base (ab11ced).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5189   +/-   ##
=======================================
  Coverage   56.29%   56.29%           
=======================================
  Files         310      310           
  Lines       20860    20860           
  Branches     4236     4236           
=======================================
  Hits        11744    11744           
  Misses       8099     8099           
  Partials     1017     1017           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bkendall bkendall merged commit 5712978 into firebase:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants