Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore, web): fix a casting error with the update method #10458

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Feb 15, 2023

Description

With the added support of updating fields containing a "." using FieldPath in update, a mistake was done during the casting of FieldPath.

This PR does not add tests because the case was already covered. There is an issue with the Firestore CI not catching the error. The method is properly failing on master locally before those changes.

CI being fixed here: #10461

Related Issues

fixes #10451

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone merged commit 696a6ba into master Feb 16, 2023
@Lyokone Lyokone deleted the fix/10451 branch February 16, 2023 08:21
@firebase firebase locked and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore] Expected a value of type 'FieldPath', but got one of type 'LegacyJavaScriptObject'
3 participants