feat(core): add support for Windows via Firebase C++ desktop SDK #10496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
changed the title
Lyokone
commented
Apr 13, 2023
| @@ -0,0 +1,155 @@ | |||
| // Copyright 2023, the Chromium project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
Main CPP file to review
Lyokone
commented
Apr 13, 2023
| # customers of the plugin. | ||
| cmake_minimum_required(VERSION 3.14) | ||
|
|
||
| set(FIREBASE_SDK_VERSION "10.5.0") |
There was a problem hiding this comment.
This is the way to auto download the SDK
Salakar
changed the title
This was referenced Apr 27, 2023
Salakar
approved these changes
May 4, 2023
Ehesp
approved these changes
May 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Windows to firebase_core using the C++ desktop SDK.
The current SDK version is downloaded and cached for the current application automatically so not extra setup is required by the user.
We use the Pigeon types to handle everything from C++ without having to create the Platform Channel ourselves.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?