Skip to content

Conversation

yamhoresh
Copy link
Contributor

@yamhoresh yamhoresh commented May 5, 2023

Added handling for the auth state of SMSCodeRequested in the custom AuthFlowBuilder example, matching the implementation of the PhoneInputView.

Description

This PR includes only a small documentation edit for the phone auth provider in the firebase_ui_auth package.
The example for building a custom widget with AuthFlowBuilder, doesn't handle the auth state for SMSCodeRequested. When copy-pasting this example, it temporarily returns an unknown state text widget during login (see image below). I've fixed the example, modifying it based on the condition in the PhoneInputView widget.

image

Related Issues

None.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Added handling for the auth state of SMSCodeRequested in the custom AuthFlowBuilder example, matching the implementation of the PhoneInputView.
@yamhoresh yamhoresh requested a review from lesnitsky as a code owner May 5, 2023 18:10
@lesnitsky lesnitsky requested a review from Lyokone May 9, 2023 11:36
@Lyokone Lyokone merged commit c56234f into firebase:master May 9, 2023
@Lyokone
Copy link
Contributor

Lyokone commented May 9, 2023

Thanks for the PR :)

@yamhoresh yamhoresh deleted the patch-2 branch May 10, 2023 07:39
@firebase firebase locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants