Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core, windows): Change the windows plugin compiling way #11594

Merged
merged 1 commit into from Sep 15, 2023

Conversation

cynthiajoan
Copy link
Collaborator

Description

To make different sdk plugins can refer to the same c++ sdk instances, which would give the ability to support the firestore->auth dependency.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone changed the title feat(core, windows) Change the windows plugin compiling way feat(core, windows): Change the windows plugin compiling way Sep 15, 2023
@Lyokone Lyokone marked this pull request as ready for review September 15, 2023 12:35
@Lyokone Lyokone merged commit 3dab95e into master Sep 15, 2023
21 of 22 checks passed
@Lyokone Lyokone deleted the feat/core-windows branch September 15, 2023 12:55
@firebase firebase locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants