Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, ios): Initialise static dictionary for custom auth domains #12157

Merged
merged 1 commit into from Jan 24, 2024

Conversation

paulw11
Copy link
Contributor

@paulw11 paulw11 commented Jan 15, 2024

Description

PR #11925 added support for custom auth domains on mobile.

Custom auto domains are stored in a static NSMutableDictionary called customAuthDomains in the FLTFirebaseCorePlugin class, keyed by the app name.

Unfortunately, this static dictionary is never initialized, so custom domains do not take effect.

This PR adds a static initializer to the FLTFirebaseCorePlugin class to initialize this dictionary

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@paulw11 paulw11 changed the title Initialize static dict for custom auth domains fix: Initialize static dict for custom auth domains Jan 15, 2024
@Lyokone Lyokone changed the title fix: Initialize static dict for custom auth domains fix(auth, ios): Initialise static dictionary for custom auth domains Jan 23, 2024
@Lyokone Lyokone merged commit 1262f3c into firebase:master Jan 24, 2024
18 of 20 checks passed
@Lyokone
Copy link
Contributor

Lyokone commented Jan 24, 2024

Thanks for the fix @paulw11

@firebase firebase locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants