New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firestore, web): migrate web to js_interop to be compatible with WASM #12169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment but LGTM
Uint8List buffer = await loadBundleSetup(2); | ||
LoadBundleTask task = firestore.loadBundle(buffer); | ||
|
||
final list = await task.stream.toList(); | ||
|
||
print( | ||
list.map((e) => e.totalDocuments), | ||
); | ||
print( | ||
list.map((e) => e.bytesLoaded), | ||
); | ||
print( | ||
list.map((e) => e.documentsLoaded), | ||
); | ||
print( | ||
list.map((e) => e.totalBytes), | ||
); | ||
print( | ||
list, | ||
); | ||
|
||
LoadBundleTaskSnapshot lastSnapshot = list.removeLast(); | ||
print(lastSnapshot.taskState); | ||
|
||
print( | ||
list.map((e) => e.taskState), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps remove or put into an ElevatedButton (or something similar) if we want to demonstrate how it works 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it was definitely something that I forgot to move :) Thanks for noticing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lyokone is there a reason that js
is still listed as dependency, or was this just missed in the PR?
There seem to be no more usages here:
https://github.com/search?q=repo%3Afirebase%2Fflutterfire+path%3A%2F%5Epackages%5C%2Fcloud_firestore%5C%2F%2F+dart%3Ajs&type=code
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
#12027
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?