Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, web): signInWithEmailAndPassword() throwing with incorrect exception code #12310

Merged
merged 2 commits into from Feb 9, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Feb 9, 2024

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

fixes #12309

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(auth, web): signInWithEmailAndPassword throwing with incorrect code fix(auth, web): signInWithEmailAndPassword() throwing with incorrect code Feb 9, 2024
@russellwheatley russellwheatley changed the title fix(auth, web): signInWithEmailAndPassword() throwing with incorrect code fix(auth, web): signInWithEmailAndPassword() throwing with incorrect exception code Feb 9, 2024
@russellwheatley russellwheatley merged commit 004f6d4 into master Feb 9, 2024
22 of 24 checks passed
@russellwheatley russellwheatley deleted the auth-12309 branch February 9, 2024 14:40
@walsha2
Copy link

walsha2 commented Feb 9, 2024

@russellwheatley Thanks for working this quickly! any idea when this will land in firebase_auth_web on pub.dev?

Anecdotally, ever since the JS Interop updates for firebase_auth it seems like things got a bit unstable. Felt like every couple of days I was chasing another odd auth related bug. Hopefully this is one of the last outstanding issues!

@deepak-agendaboa
Copy link

@russellwheatley any update?

@russellwheatley
Copy link
Member Author

@deepak-agendaboa - will be released on Monday 👍

@firebase firebase locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth_web] signInWithEmailAndPassword returns unknown error code instead of invalid-credential
5 participants