Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firebase_storage): use camel case style for "FlutterFire" in README.md #8752

Merged
merged 1 commit into from
May 23, 2022

Conversation

nilsreichardt
Copy link
Contributor

Description

To be consistent with other packages, we should write "Flutterfire" in camel case style.

Related Issues

Part of #8745

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@nilsreichardt
Copy link
Contributor Author

Sorry if this is a bit of work to review 22 PRs which also could be only 2 PRs. I thought it's better to split them up to follow conventional commits better and having less changes in a single PR, so someone can better understand the changes when clicking on the linked PR/commit in the changelog: DOCS: use camel case style for "FlutterFire" in REDME.md (#8291) [7b4e06db

@russellwheatley russellwheatley changed the title docs(firebase_storage): use camel case style for "FlutterFire" in REDME.md docs(firebase_storage): use camel case style for "FlutterFire" in README.md May 23, 2022
@russellwheatley russellwheatley merged commit 5c5dcaf into firebase:master May 23, 2022
@firebase firebase locked and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants