Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage, web): bridge putString to uploadByteResumable #8901

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Jun 14, 2022

Description

Keep the putString method by bridging it to uploadByteResumable

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley merged commit 1f4e1df into firebase:v9/storage Jun 16, 2022
russellwheatley added a commit that referenced this pull request Jun 29, 2022
* feat(storage, web): interate with web v9 SDK

* feat(storage, web): bridge putString to uploadByteResumable (#8901)

* chore(storage): rm unneeded api

* chore(storage): rm unneeded class

* chore(storage, web): rm unused code

Co-authored-by: Guillaume Bernos <guillaume@bernos.dev>
@firebase firebase locked and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants