Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [firebase_ui_auth] [firebase_ui_oauth] Allow for custom labels to be used for custom OAuth providers #9858

Merged
merged 6 commits into from
Nov 24, 2022
Merged

feat: [firebase_ui_auth] [firebase_ui_oauth] Allow for custom labels to be used for custom OAuth providers #9858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
35f27d5
Added `label` field to `ThemedOAuthProviderButtonStyle`
Rexios80 Nov 4, 2022
9518ed4
Added comment
Rexios80 Nov 4, 2022
8f0b11c
Code simplification
Rexios80 Nov 4, 2022
70fc068
Formatting
Rexios80 Nov 4, 2022
c0a003c
Removed dependency overrides
Rexios80 Nov 4, 2022
7fb28da
Merge remote-tracking branch 'origin/master' into feature/custom-oaut…
Rexios80 Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/firebase_ui_auth/lib/src/widgets/internal/oauth_provider_button.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ class OAuthProviderButton extends StatelessWidget {
),
label: variant == OAuthButtonVariant.icon
? ''
: resolveProviderButtonLabel(provider.providerId, labels),
: provider.style.label ??
resolveProviderButtonLabel(provider.providerId, labels),
auth: auth,
);

Expand Down
5 changes: 5 additions & 0 deletions packages/firebase_ui_oauth/lib/src/oauth_provider_button_style.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ abstract class ThemedOAuthProviderButtonStyle {
double get iconPadding => 0;
String get assetsPackage;

/// A custom label string.
///
/// Required for custom OAuth providers.
String? get label => null;

/// {@macro ui.oauth.themed_oauth_provider_button_style}
const ThemedOAuthProviderButtonStyle();

Expand Down